Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solhint Conflicting Naming Convention for Event Names #600

Closed
soroush-khoshnoudi opened this issue Sep 1, 2024 · 3 comments
Closed

Solhint Conflicting Naming Convention for Event Names #600

soroush-khoshnoudi opened this issue Sep 1, 2024 · 3 comments
Assignees
Labels
awaiting user feedback awaiting user feedback

Comments

@soroush-khoshnoudi
Copy link

When developing smart contracts in Solidity, it is a common convention to write event names in CapWord style (also known as PascalCase), such as BeforeTransfer, AfterTransfer, etc., as per Solidity documentation and best practices. However, when I run Solhint to lint my code, I encounter an error stating that "event name should be camel case." This creates a conflict between Solhint's linting rules and the recommended Solidity naming conventions.

solidity event name style guide

@HarutProtofire
Copy link
Collaborator

HarutProtofire commented Nov 21, 2024

Hello @soroush-khoshnoudi, we apologize for the delay in addressing this. Could you please provide the code causing the issue so we can review it?

@dbale-altoros
Copy link
Collaborator

@soroush-khoshnoudi sorry this seems like a confusion... i will check the code but I'm pretty sure that if you write the event with a captal letter, the error will not be triggered...
We should change the rule name and the error message although

@dbale-altoros
Copy link
Collaborator

@soroush-khoshnoudi this is addressed in 5.0.4 version

thanks for pointing it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting user feedback awaiting user feedback
Projects
None yet
Development

No branches or pull requests

3 participants