-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repeated int32 not parsing properly #390
Comments
From the comments on that issue, it also looks like repeated fields should serialize with packed=true by default when using proto3 semantics. |
i just ran into this too, for proto3 it looks like packed=true is the default, and this code needs to be fixed. as a temporary workaround you can just specify packed=true or packed=false on all your repeated primitive fields. |
Closing this for now. Feel free to send a pull request if this is still a requirement. |
The entire context can be seen here grpc/grpc#5174 . @dsymonds from Google says he's going to work on fixing the documentation to make the expected behavior more explicit, but that a repeated int32 field without packed=true specified should still be able to parse as if packed=true were set.
The text was updated successfully, but these errors were encountered: