Fix the race in the registry #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 6, 2018 11:22
Signed-off-by: beorn7 <[email protected]>
Signed-off-by: beorn7 <[email protected]>
Signed-off-by: beorn7 <[email protected]>
This was referenced Dec 6, 2018
stuartnelson3
approved these changes
Dec 6, 2018
|
@beorn7 thanks for seeing this through. really appreciate it. any chance there will be a new tag soon that we can use to grab this update ? |
|
I'll cut v0.9.2 today. |
rphillips
added a commit
to rphillips/origin
that referenced
this pull request
Jun 4, 2019
rphillips
added a commit
to rphillips/prometheus-client_golang
that referenced
this pull request
Jun 4, 2019
rphillips
added a commit
to rphillips/origin
that referenced
this pull request
Jun 5, 2019
rphillips
added a commit
to rphillips/origin
that referenced
this pull request
Jun 5, 2019
…o race fix to 4.1 This is fixed in 4.2. ref: prometheus/client_golang#513 ref: https://bugzilla.redhat.com/show_bug.cgi?id=1713098
rphillips
added a commit
to rphillips/origin
that referenced
this pull request
Jun 5, 2019
…race fix to 4.1 This is fixed in 4.2. ref: prometheus/client_golang#513 ref: https://bugzilla.redhat.com/show_bug.cgi?id=1713098
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #512 and subsequently istio/istio#10236 .
@douglas-reid , this incorporates your findings. Please have a look.