Fixes 498 #499
Merged
Fixes 498 #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tutil Signed-off-by: PhilipGough <[email protected]>
philipgough
force-pushed
the
fixes-498
branch
from
0aba90e
to
9e38e67
Compare
beorn7
requested changes
Nov 15, 2018
prometheus/testutil/testutil.go
Outdated
| // text format and creates a readable error message from the result. | ||
| func notMatchingError(got, want []*dto.MetricFamily) error { | ||
| // compare encodes both provided slices of metric families into the | ||
| // text format compares their string message and returns an error if they do not match. |
There was a problem hiding this comment.
Nit: commas after "format" and "message".
prometheus/testutil/testutil.go
Outdated
| func notMatchingError(got, want []*dto.MetricFamily) error { | ||
| // compare encodes both provided slices of metric families into the | ||
| // text format compares their string message and returns an error if they do not match. | ||
| // In case of error, prints a readable error message from the result. |
There was a problem hiding this comment.
This sounds like it would call fmt.Println or something. Perhaps just mention that the returned error will contain the encoded text of both, got and want.
Signed-off-by: PhilipGough <[email protected]>
philipgough
force-pushed
the
fixes-498
branch
from
9e38e67
to
f9739b3
Compare
|
@beorn7 thanks, amended! |
beorn7
approved these changes
Nov 15, 2018
|
Thanks, too. Merging now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #498
@beorn7 is this close to what you had in mind? If not let me know and I can revise.