Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promhttp: Rename exemplarAdd #1120

Closed
kakkoyun opened this issue Aug 22, 2022 · 4 comments · Fixed by #1122
Closed

promhttp: Rename exemplarAdd #1120

kakkoyun opened this issue Aug 22, 2022 · 4 comments · Fixed by #1122
Labels
good first issue help wanted

Comments

@kakkoyun
Copy link
Member

Thinking loudly: I think the function name exemplarAdd() doesn't make it obvious the metric is incremented. Maybe renaming it to addWithExemplar() may clarify it?

Originally posted by @pracucci in #1118 (comment)

cc @hairyhenderson
@kakkoyun kakkoyun mentioned this issue Aug 22, 2022
Merged
@kaustav-mondal
Copy link

Hi @kakkoyun, may I take this up?

@kakkoyun
Copy link
Member Author

I think @hairyhenderson is already on it.

@hairyhenderson
Copy link
Contributor

Yup, I'm on this!

@hairyhenderson hairyhenderson mentioned this issue Aug 22, 2022
Merged
@hairyhenderson
Copy link
Contributor

I've issued #1122 for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify exemplar(Add|Observe) by renaming to (add|observe)WithExemplar hairyhenderson/client_golang
3 participants
@kakkoyun @hairyhenderson @kaustav-mondal