Skip to content

Commit f900abb

Browse files
committed
Review comments
Signed-off-by: Shivanth <[email protected]>
1 parent 6817e54 commit f900abb

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

prometheus/histogram.go

+5-5
Original file line numberDiff line numberDiff line change
@@ -1886,16 +1886,16 @@ func validateExemplars(exemplars []*dto.Exemplar) error {
18861886
//
18871887
// zeroBucket counts all (positive and negative)
18881888
// observations in the zero bucket (with an absolute value less or equal
1889-
// the current threshold)
1889+
// the current threshold).
18901890
// positiveBuckets and negativeBuckets are separate maps for negative and positive
18911891
// observations. The map's value is an int64, counting observations in
18921892
// that bucket. The map's key is the
18931893
// index of the bucket according to the used
1894-
// Schema. Index 0 is for an upper bound of 1.
1894+
// Schema. Index 0 is for an upper bound of 1 in positive buckets and for a lower bound of -1 in negative buckets.
18951895
// NewConstNativeHistogram returns an error if
1896-
// 1.the length of labelValues is not consistent with the variable labels in Desc or if Desc is invalid.
1897-
// 2.the schema passed is not between 8 and -4
1898-
// 3.the sum of counts in the bucket do not equal count
1896+
// - the length of labelValues is not consistent with the variable labels in Desc or if Desc is invalid.
1897+
// - the schema passed is not between 8 and -4
1898+
// - the sum of counts in the bucket do not equal count when sum is not Nan
18991899
func NewConstNativeHistogram(
19001900
desc *Desc,
19011901
count uint64,

0 commit comments

Comments
 (0)