-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
remove float32 variant, relocate into separate file
This change removes the float32 variant of the AlmostEqual funcs, that we will likely never use. This change also relocates the function into a separate file to avoid modifying a file that's a fork of another vendored package.
- Loading branch information
Showing
2 changed files
with
40 additions
and
92 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
package internal | ||
|
||
import ( | ||
"math" | ||
) | ||
|
||
// minNormalFloat64 is the smallest positive normal value of type float64. | ||
var minNormalFloat64 = math.Float64frombits(0x0010000000000000) | ||
|
||
// AlmostEqualFloat64 returns true if a and b are equal within a relative error | ||
// of epsilon. See http://floating-point-gui.de/errors/comparison/ for the | ||
// details of the applied method. | ||
// | ||
// This function is copy/paste to avoid a dependency. | ||
// https://github.com/beorn7/floats | ||
func AlmostEqualFloat64(a, b, epsilon float64) bool { | ||
if a == b { | ||
return true | ||
} | ||
absA := math.Abs(a) | ||
absB := math.Abs(b) | ||
diff := math.Abs(a - b) | ||
if a == 0 || b == 0 || absA+absB < minNormalFloat64 { | ||
return diff < epsilon*minNormalFloat64 | ||
} | ||
return diff/math.Min(absA+absB, math.MaxFloat64) < epsilon | ||
} | ||
|
||
// AlmostEqualFloat64s is the slice form of AlmostEqualFloat64. | ||
func AlmostEqualFloat64s(a, b []float64, epsilon float64) bool { | ||
if len(a) != len(b) { | ||
return false | ||
} | ||
for i := range a { | ||
if !AlmostEqualFloat64(a[i], b[i], epsilon) { | ||
return false | ||
} | ||
} | ||
return true | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters