Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality #28

Open
nvtkaszpir opened this issue Feb 19, 2022 · 0 comments
Open

Improve code quality #28

nvtkaszpir opened this issue Feb 19, 2022 · 0 comments

Comments

@nvtkaszpir
Copy link
Contributor

Some ideas to improve code quality

  • Add pre-commit to run some linters

    • makrdownlint-cli (with some exceptions because it is extremely annoying on defaults)
    • Run hack/check_urls.sh checker for runbooks urls
    • Run hack/spider.sh to check dead urls to detect.. guess what, dead urls!
  • Add it to CI for more strict code quality checks (if someone does not use pre-commits... such as in web editing via GitHub)
    That may be a bit more problematic than it sounds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant