You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The clusterinfo package pkg/clusterinfo is designed to relay updates to collectors periodically. The way it is written seems complicated. Collectors are registered with the clusterinfo package and are sent information over a channel periodically. The cluserinfo collector has already been refactored to use the collector.Collector interface in collector/cluster_info.go.
One problem with the current implementation is that the collectors need to have a channel to receive updates, however neither the collector nor the clusterinfo package handle closing those channels. This could potentially leak resources.
We should design a more friendly API for collectors that need this information. Additionally, we should decide if this functionality needs to exist at all.
References:
PR adding collector that needs to register with clusterinfo #639
Original Implementation #176
The text was updated successfully, but these errors were encountered:
The clusterinfo package
pkg/clusterinfo
is designed to relay updates to collectors periodically. The way it is written seems complicated. Collectors are registered with the clusterinfo package and are sent information over a channel periodically. The cluserinfo collector has already been refactored to use thecollector.Collector
interface incollector/cluster_info.go
.One problem with the current implementation is that the collectors need to have a channel to receive updates, however neither the collector nor the clusterinfo package handle closing those channels. This could potentially leak resources.
We should design a more friendly API for collectors that need this information. Additionally, we should decide if this functionality needs to exist at all.
References:
PR adding collector that needs to register with clusterinfo #639
Original Implementation #176
The text was updated successfully, but these errors were encountered: