Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github reporting module creates a new issue everytime for the same finding #5347

Closed
monishbb opened this issue Jul 1, 2024 · 1 comment
Closed
Assignees
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@monishbb
Copy link

monishbb commented Jul 1, 2024

Nuclei version:

3.2.9

Current Behavior:

Using update-existing in Github reporting module does not work, it still creates a new issue for an already existing issue

allow-list:
  severity: info, low, high, critical, medium

# GitHub contains configuration options for GitHub issue tracker
github:
  # issue-label is the label of the created issue type
  issue-label: security
  # update-existing is the boolean which tells if the existing, opened issue should be updated or new one should be created
  update-existing: true
  # duplicate-issue-check flag to enable duplicate tracking issue check.
  duplicate-issue-check: true
  # username of the github accont being used
  username: test-user
  # token is the token for GitLab account
  token: test-token
  # project-name is the name/id of the project(repository)
  project-name: "1234"

Expected Behavior:

Existing issues on Github should have been updated instead of a new issue being created

Steps To Reproduce:

  1. Use https://github.com/projectdiscovery/nuclei-action
  2. Pass the above report config:
- name: Nuclei - Vulnerability Scan
          uses: projectdiscovery/nuclei-action@main
          with:
            target: https://www.example.com
            github-report: true
            github-token: ${{ github.token }}
            report-config: vapt-config/nuclei-reporting.yaml
            config: vapt-config/nuclei-config.yaml
            flags: -disable-unsigned-templates
  1. Multiple issues are created for the same findings if run multiple times

Anything else:

#3429
projectdiscovery/nuclei-action#60

@monishbb monishbb added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jul 1, 2024
@dogancanbakir dogancanbakir self-assigned this Jul 1, 2024
@dogancanbakir
Copy link
Member

It should be duplicate-issue-check: true https://github.com/projectdiscovery/nuclei/blob/dev/cmd/nuclei/issue-tracker-config.yaml#L35 instead of update-existing: true. Example config,

image

and result
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

2 participants