Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot find the custom Chrome path when using both -sc and -scp options simultaneously. #970

Closed
zrquan opened this issue Jul 27, 2024 · 0 comments · Fixed by #979
Closed

Cannot find the custom Chrome path when using both -sc and -scp options simultaneously. #970

zrquan opened this issue Jul 27, 2024 · 0 comments · Fixed by #979
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Milestone
katana v1.1.1

Comments

@zrquan
Copy link
Contributor

zrquan commented Jul 27, 2024

katana version:

Current version: v1.1.0

Current Behavior:

If both -sc and -scp options are used simultaneously, it will exit directly if Chrome is not found in the default paths, even if the -scp option specifies the correct Chrome path.

Expected Behavior:

The -scp specified Chrome path should take priority.

Steps To Reproduce:

Anything else:
@zrquan zrquan added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jul 27, 2024
This was referenced Jul 27, 2024
Closed
Merged
@dogancanbakir dogancanbakir linked a pull request Jul 31, 2024 that will close this issue
ignore default paths if -scp is provided #979
Merged
@Mzack9999 Mzack9999 added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Sep 10, 2024
@dogancanbakir dogancanbakir added this to the katana v1.1.1 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
katana v1.1.1
Development

Successfully merging a pull request may close this issue.

ignore default paths if -scp is provided zrquan/katana
ignore default paths if -scp is provided
3 participants
@Mzack9999 @zrquan @dogancanbakir