Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify serviceAccounts as tenant owner #645

Merged
merged 1 commit into from
Sep 27, 2022
Merged

docs: clarify serviceAccounts as tenant owner #645

merged 1 commit into from
Sep 27, 2022

Conversation

lalyos
Copy link
Contributor

@lalyos lalyos commented Sep 26, 2022

after some discussion on slack with @prometherion here is my attempt to make the docs more clear.

we don't know how's the platform admin is managing these ServiceAccount
We saw from other end-users that their best practice is to create a Namespace containing all the ServiceAccount resources that will be used as Tenant Owner (e.g: tenant-system) in order to user its group in the Capsule Configuration (e.g.: system:serviceaccounts:tenant-system).

@netlify
Copy link

netlify bot commented Sep 26, 2022 •
edited
Loading

✅ Deploy Preview for capsule-documentation canceled.

Name Link
🔨 Latest commit a1243ee
🔍 Latest deploy log https://app.netlify.com/sites/capsule-documentation/deploys/6331d5409eb33e0008167d59

@prometherion prometherion added this to the v0.2.0 milestone Sep 26, 2022
@prometherion prometherion added the documentation Improvements or additions to documentation label Sep 26, 2022
prometherion
prometherion requested changes Sep 26, 2022
View reviewed changes
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a note regarding the commit message that is violating the semantic commit messages.

I would suggest something has fix(docs): clarifying serviceaccount as tenant owner

@lalyos
Copy link
Contributor Author

lalyos commented Sep 26, 2022

fixed the commit message

bsctl
bsctl approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@bsctl bsctl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lalyos thanks for your work, it lgtm.

@lalyos lalyos changed the title [docs] clarify serviceAccounts as tenant owner docs: clarify serviceAccounts as tenant owner Sep 26, 2022
@prometherion prometherion merged commit e0dbf47 into projectcapsule:master Sep 27, 2022
@prometherion prometherion modified the milestones: v0.2.0, v0.1.3 Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prometherion prometherion prometherion approved these changes

@bsctl bsctl bsctl approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@lalyos @bsctl @prometherion