Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded dependencies #104

Closed
ibro45 opened this issue Jan 31, 2024 · 4 comments
Closed

Remove unneeded dependencies #104

ibro45 opened this issue Jan 31, 2024 · 4 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@ibro45
Copy link
Collaborator

ibro45 commented Jan 31, 2024

  • lightly
  • hydra
  • omegaconf
  • anything else? @surajpaib

These were the packages installed as dependencies for Lighter after I set up a conda env with pytorch & torchvision:
image

@ibro45 ibro45 added the dependencies Pull requests that update a dependency file label Jan 31, 2024
Copy link

dosubot bot commented Jan 31, 2024

🤖

Hey @ibro45, long time no see! Hope you're doing great 😄👋

Based on the context provided, it seems there might be a misunderstanding about the dependencies of the Lighter project. The dependencies you mentioned - lightly, hydra, and omegaconf - are not listed in the pyproject.toml file of the Lighter project. The actual dependencies listed are:

  • python
  • torch
  • pandas
  • pytorch-lightning
  • fire
  • loguru
  • lightly
  • torchmetrics
  • tensorboard
  • requests
  • monai

As for the 'lightly' package, it provides a streamlined way to conduct deep learning experiments using PyTorch/PyTorch Lightning. It offers functionalities such as model setup, DataLoader specifics, handling of datasets, samplers, and collate functions, metrics, postprocessing, inferer, forward pass, base step, loss calculation, logging, DataLoader instantiation, optimizers configuration, and setup. You can find more details about these functionalities in the lighter/system.py file.

Therefore, removing any of these dependencies might break the functionality of the project unless the code is refactored to not use the features provided by the removed dependency. If you believe there are unnecessary dependencies, could you please provide more specific information about the use cases of the Lighter project where these dependencies are not needed? This would help in determining whether these dependencies can be safely removed or not.

Sources


This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@ibro45
Copy link
Collaborator Author

ibro45 commented Jan 31, 2024

Don't confuse lightly with lighter. Also, I don't know how poetry works exactly, but those dependencies are present in https://github.com/project-lighter/lighter/blob/main/poetry.lock.

It seems that hydra and therefore omegaconf are installed by lightly: https://github.com/lightly-ai/lightly/blob/master/tox.ini

@surajpaib
Copy link
Collaborator

[tool.poetry.dependencies]

Only things here are packaged with poetry. So anything that shows up is either a direct or an indirect dependency of the packages mentioned.

@surajpaib
Copy link
Collaborator

We should remove lightly in that case as it seems to have somehow remained there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants