-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded dependencies #104
Comments
🤖 Hey @ibro45, long time no see! Hope you're doing great 😄👋 Based on the context provided, it seems there might be a misunderstanding about the dependencies of the Lighter project. The dependencies you mentioned - lightly, hydra, and omegaconf - are not listed in the
As for the 'lightly' package, it provides a streamlined way to conduct deep learning experiments using PyTorch/PyTorch Lightning. It offers functionalities such as model setup, DataLoader specifics, handling of datasets, samplers, and collate functions, metrics, postprocessing, inferer, forward pass, base step, loss calculation, logging, DataLoader instantiation, optimizers configuration, and setup. You can find more details about these functionalities in the lighter/system.py file. Therefore, removing any of these dependencies might break the functionality of the project unless the code is refactored to not use the features provided by the removed dependency. If you believe there are unnecessary dependencies, could you please provide more specific information about the use cases of the Lighter project where these dependencies are not needed? This would help in determining whether these dependencies can be safely removed or not. SourcesThis response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research. Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant. If you want to continue the conversation, start your reply with @dosu-bot. |
Don't confuse lightly with lighter. Also, I don't know how poetry works exactly, but those dependencies are present in https://github.com/project-lighter/lighter/blob/main/poetry.lock. It seems that hydra and therefore omegaconf are installed by lightly: https://github.com/lightly-ai/lightly/blob/master/tox.ini |
Line 43 in ca9794e
Only things here are packaged with poetry. So anything that shows up is either a direct or an indirect dependency of the packages mentioned. |
We should remove lightly in that case as it seems to have somehow remained there |
These were the packages installed as dependencies for Lighter after I set up a conda env with pytorch & torchvision:
![image](https://private-user-images.githubusercontent.com/18015788/301232712-5a0f40e6-9c16-4954-bf33-f6e475ae0d23.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg3NDUyNTUsIm5iZiI6MTczODc0NDk1NSwicGF0aCI6Ii8xODAxNTc4OC8zMDEyMzI3MTItNWEwZjQwZTYtOWMxNi00OTU0LWJmMzMtZjZlNDc1YWUwZDIzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA1VDA4NDIzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYxNmRjNGYyMzZhNWNiN2Y4Mjk3MWEyYWY4ZDBlZTk0NDZhMjM4MjMyOWJhY2Q5MGQ3ZWJmNjk5ZTc0NGM2OWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.hp_DraOqpE4DArQT-kJ5JZACkuDoepC5Sm1hEv87heI)
The text was updated successfully, but these errors were encountered: