-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-5887] - Return source status #5518
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5518 +/- ##
=====================================
Coverage 94.1% 94.1%
=====================================
Files 371 371
Lines 31569 31574 +5
Branches 3385 3385
=====================================
+ Hits 29712 29717 +5
+ Misses 1205 1203 -2
- Partials 652 654 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is COST-5886 the correct issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Michael! And Yes I did link the wrong issue Sorry! 5887 not 5886
Full smokes passed. |
/retest |
Jira Ticket
COST-5887
Description
This change will correctly raise an exception for Forbidden errors when we fail to list GCP bigquery tables. This one is a rare case that happens when the correct roles are set but the Organisation has additional strict VPC Service Controls.
Testing this was kinda a pain!
...: print(table.full_table_id)
This should raise a forbidden error similar to the alert.
Release Notes