[COST-5919] Update OCP VMs provider map #5512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5512 +/- ##
=======================================
- Coverage 94.1% 94.1% -0.0%
=======================================
Files 371 371
Lines 31569 31569
Branches 3385 3385
=======================================
- Hits 29713 29712 -1
- Misses 1204 1205 +1
Partials 652 652 |
bacciotti
changed the title
1 task
bacciotti
added
the
smoke-tests
|
/retest |
|
/retest |
lcouzens
reviewed
Feb 25, 2025
| @@ -1335,7 +1356,7 @@ def test_execute_query_with_group_by_order_by_and_limit(self): | |||
| "filter[limit]": 5, | |||
| } | |||
|
|
|||
| url = f'{reverse("reports-openshift-cpu")}?' + urlencode(params, quote_via=quote_plus) | |||
| url = f"{reverse('reports-openshift-cpu')}?" + urlencode(params, quote_via=quote_plus) | |||
There was a problem hiding this comment.
Curious why we changed these?
There was a problem hiding this comment.
🤷🏻 auto formatting changed these
|
/retest |
lcouzens
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-5919
Description
This change will modify API provider map to display distributed_cost in endpoints.
Testing
/v1/reports/openshift/resources/virtual-machines/?limit=20platform_distributed,worker_unallocated_distributed,network_unattributed_distributed,storage_unattributed_distributedanddistributed. (probably without values because we need some SQL changes).Release Notes