Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5861] OCP on AWS managed population #5484

Merged
merged 11 commits into from
Feb 11, 2025
Merged

[COST-5861] OCP on AWS managed population #5484

merged 11 commits into from
Feb 11, 2025

Conversation

myersCody
Copy link
Contributor

Jira Ticket

COST-5861

Description

This change will move the summary logic to managed tables.

Testing

trino:org1234567> select sum(unblended_cost), namespace from reporting_ocpawscostlineitem_project_daily_summary where resource_id='i-55555556' and year='2025' and month='1' group by namespace;
       _col0        |      namespace
--------------------+----------------------
   5.07663989925049 | Network unattributed
 35.712000000000025 | Worker unallocated
 35.712000000000025 | cost-management
(3 rows)

trino:org1234567> select sum(unblended_cost), namespace from managed_reporting_ocpawscostlineitem_project_daily_summary where resource_id='i-55555556' and year='2025' and month='1' group by namespace;
       _col0        |      namespace
--------------------+----------------------
   5.07663989925049 | Network unattributed
 35.712000000000025 | Worker unallocated
 35.712000000000025 | cost-management

Release Notes

  • proposed release note
* [COST-5861](https://issues.redhat.com/browse/COST-5861) OCP on AWS managed population

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (e0670f3) to head (9753521).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5484     +/-   ##
=======================================
- Coverage   94.1%   94.1%   -0.0%     
=======================================
  Files        371     371             
  Lines      31612   31598     -14     
  Branches    3386    3385      -1     
=======================================
- Hits       29744   29727     -17     
- Misses      1217    1218      +1     
- Partials     651     653      +2     

@myersCody myersCody added the aws-smoke-tests pr_check will build the image and run aws + ocp on aws smoke tests label Feb 7, 2025
@myersCody
Copy link
Contributor Author

/retest

@myersCody myersCody marked this pull request as ready for review February 10, 2025 19:45
@myersCody myersCody requested review from a team as code owners February 10, 2025 19:45
lcouzens
lcouzens previously approved these changes Feb 11, 2025
Copy link
Contributor

@lcouzens lcouzens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking Good Cody!

@myersCody
Copy link
Contributor Author

/retest

@lcouzens lcouzens added smoke-tests pr_check will build the image and run minimal required smokes and removed aws-smoke-tests pr_check will build the image and run aws + ocp on aws smoke tests labels Feb 11, 2025
@lcouzens
Copy link
Contributor

/retest

@myersCody myersCody enabled auto-merge (squash) February 11, 2025 19:11
@myersCody myersCody merged commit 6f9aab6 into main Feb 11, 2025
14 checks passed
@myersCody myersCody deleted the aws_managed_summary branch February 11, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants