Skip to content

Conversation

@pawelpaszki
Copy link
Contributor

@pawelpaszki pawelpaszki commented Nov 21, 2025

Issue link

RHOAIENG-39320

What changes have been made

test: ui upgrade tests

Verification steps

structure of the containerEnvFile

OCP_ADMIN_USER_USERNAME=htpasswd-cluster-admin-user
OCP_ADMIN_USER_PASSWORD=<same as for ods-ci tests for that user>
TEST_USER_USERNAME=ldap-admin1
TEST_USER_PASSWORD=<same as for ods-ci tests for that user>

verification steps:

oc login # with htpasswd-cluster-admin-user to a cluster with RHOAI 3.x (and RHBoK) installed
mkdir results
touch ../containerEnvFile # see the content above
# build the image as follows
podman build --arch=amd64 -f images/tests/Dockerfile -t quay.io/opendatahub/codeflare-sdk-tests:latest .
# run pre-upgrade tests and confirm they pass
podman run --rm -it --pull "never" \ 
  --platform linux/amd64 \
  -v ~/.kube/config:/codeflare-sdk/tests/.kube/config:ro \
  -v ./results:/codeflare-sdk/tests/results:Z --env-file ../containerEnvFile \
  quay.io/opendatahub/codeflare-sdk-tests:latest -m pre_upgrade
# run post-upgrade tests and confirm they pass
podman run --rm -it --pull "never" \ 
  --platform linux/amd64 \
  -v ~/.kube/config:/codeflare-sdk/tests/.kube/config:ro \
  -v ./results:/codeflare-sdk/tests/results:Z --env-file ../containerEnvFile \
  quay.io/opendatahub/codeflare-sdk-tests:latest -m post_upgrade

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.21%. Comparing base (158224f) to head (ddf017f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #942   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files          24       24           
  Lines        2128     2128           
=======================================
  Hits         2005     2005           
  Misses        123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pawelpaszki pawelpaszki force-pushed the RHOAIENG-39320 branch 3 times, most recently from 3b966cd to 63a88b8 Compare November 27, 2025 10:22
@pawelpaszki pawelpaszki marked this pull request as ready for review November 27, 2025 10:24
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 27, 2025
Copy link
Contributor

@kryanbeane kryanbeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both pre and post upgrade tests passed, lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kryanbeane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit b713531 into project-codeflare:main Nov 27, 2025
20 checks passed
@pawelpaszki pawelpaszki deleted the RHOAIENG-39320 branch November 27, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants