add getMachineSet function and machineSet test in accordance with instascale issue #193_Add_functional_tests #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
abhijeet-dhumal
force-pushed
the
add_getMachineSet_func
branch
from
41cd2aa
to
8060cd3
Compare
abhijeet-dhumal
changed the title
abhijeet-dhumal
force-pushed
the
add_getMachineSet_func
branch
from
8060cd3
to
44cd713
Compare
…tascale issue #193_Add_functional_tests
abhijeet-dhumal
force-pushed
the
add_getMachineSet_func
branch
from
7dae6fa
to
7f16a6b
Compare
|
/lgtm |
|
/lgtm |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhijeet-dhumal, astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 1edd775
into
project-codeflare:main
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Add functional tests
What changes have been made
Added functions
MachineSetandMachineSetReplicasin accordance with instascale issue #193_Add_functional_tests ~ Guided by - @sutaakarChecks