Workaround for node bug 56219 #1522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs/node#56219 breaks our base-64 encoder. Node is off spec and should release fix quickly. Normally I wouldn't patch but in this case workaround is innocuous. Fixes matter-js#1516
|
Review changes with |
pullapprove
bot
requested review from
Apollon77,
turon,
vves and
woody-apple
Apollon77
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodejs/node#56219 breaks our base-64 encoder. Node is off spec and should release fix quickly. Normally I wouldn't patch but in this case workaround is innocuous.
Fixes #1516