From 7c17b94267958c105977402bbbea56c5fc113275 Mon Sep 17 00:00:00 2001 From: Kevin Schoedel Date: Wed, 27 Oct 2021 09:48:41 -0400 Subject: [PATCH] Size reports: Change the highlight threshold. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit #### Problem Size reports comments should highlight a reasonable number of size increases — enough to flag significant changes, but no so many that they cause fatigue. #### Change overview Changed the threshold to 0.2%, which, based on recent commits, should trigger on about 20% of PRs (not 20% of builds). #### Testing Offline runs on past data. --- .github/workflows/bloat_check.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/bloat_check.yaml b/.github/workflows/bloat_check.yaml index 852d22462138e6..6803f088da6578 100644 --- a/.github/workflows/bloat_check.yaml +++ b/.github/workflows/bloat_check.yaml @@ -46,7 +46,7 @@ jobs: run: | scripts/tools/memory/gh_report.py \ --verbose \ - --report-increases 1 \ + --report-increases 0.2 \ --report-pr \ --github-comment \ --github-limit-artifact-pages 50 \