Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup IM status code #9726

Closed
yunhanw-google opened this issue Sep 15, 2021 · 3 comments
Closed

Cleanup IM status code #9726

yunhanw-google opened this issue Sep 15, 2021 · 3 comments
Assignees
@yunhanw-google

Comments

@yunhanw-google
Copy link
Contributor

--Typedefes and constexprs for all of the places we currently have uint32_t and PRIx32 would be nice, but don't need to block this PR.

Yes, would follow-up it in next PR for status code, thanks
@yunhanw-google yunhanw-google self-assigned this Sep 15, 2021
@yunhanw-google yunhanw-google changed the title > Two general comments: is protocolCode actually 32-bit? I thought it was 16-bit. Second, since we're already touching all of them, can we replace all of the intXX_t types with and format strings with typedefs and constexprs? Cleanup IM status code Sep 15, 2021
@yunhanw-google yunhanw-google mentioned this issue Sep 15, 2021
Merged
@bzbarsky-apple
Copy link
Contributor

@yunhanw-google What is this issue actually about?

@woody-apple
Copy link
Contributor

Issue Review: @mrjerryjohns to follow up.

@yunhanw-google
Copy link
Contributor Author

yunhanw-google commented Jul 22, 2022 •
edited
Loading

not be the issue now, status has updated with 8bit in latest code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yunhanw-google yunhanw-google

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yunhanw-google @woody-apple @bzbarsky-apple