-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IM encoding spec rename/update several IB, needs to update the corresponding code in app/MessageDef #9520
Comments
Mentioned here: #9510 (comment) Among other things, SubscriptionID needs to be changed from 64bit to 32bit. Likewise, the special 'invalid' subscription ID used in the PR, UINT64_MAX, needs handling and a #define or constexpr. |
yep, agree. thanks |
I think it'd best if we broke this down into some smaller issues/bits of work, since there are a number of fairly significant changes involved:
I think it'd be best if we focused on each interaction and assigned a distinct issue for each. |
All have been completed. |
Problem
IM encoding spec rename/update several IB, needs to update the corresponding code in app/MessageDef
The text was updated successfully, but these errors were encountered: