Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI Testing] Improve TC_SWTCH testing on CI #36884

Open
arkq opened this issue Dec 18, 2024 · 2 comments
Open

[CI Testing] Improve TC_SWTCH testing on CI #36884

arkq opened this issue Dec 18, 2024 · 2 comments

Comments

@arkq
Copy link
Contributor

arkq commented Dec 18, 2024

Test issue(s)

The TC_SWTCH runs all test cases for endpoint 1, 2, 3, 4. However, not all this endpoints have features required for particular tests, so some of them are skipped. Such testing scenario fails in case when we enforce all test cases to pass (fail-on-skip) in order to catch tests skipped by mistake (e.g. endpoint has been changed).

For now the CI runs are filtered by endpoint and matching tests cases, e.g.: on endpoint 1 only test_TC_SWTCH_2_2 is run. However, this is also not ideal, because one might add another test case to the class without adding --test-case to the script args, and such test will not be run on CI at all...

Maybe this TC_SWTCH.py file should be split into particular test cases, so testing on CI will be more relievable and resilient to configuration omissions.

Platform

other

Anything else?

No response

@cecille
Copy link
Contributor

cecille commented Dec 19, 2024

Some are skipped on purpose. The all clusters app is set up to run these tests across all endpoints. This is always the case, BTW, whether or not tests are selected automatically or by PICS.

@arkq
Copy link
Contributor Author

arkq commented Dec 19, 2024

tests are selected automatically or by PICS.

Test cases are selected based on particular switch cluster features being present on selected endpoint. And that is done by the test script itself, not by the configuration passed to the test script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants