You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Enforce DataModel::Provider everywhere #36319 (comment) : mLastSuccessfullyWrittenPath and mProcessingAttributePath are tightly coupled so we may be able to save some code/logic/flash/ram. Review their use and coupling and update the code accordingly
The text was updated successfully, but these errors were encountered:
For the 3rd item, I could not find an immediate dedup logic for mLastSuccessfullyWrittenPath and mProcessingAttributePath as their code paths are updated at separate times. Deduplicating members within our handlers will likely require separate consideration.
Once we have a single codepath, some optimizations become clearer:
DataModel::Provider
everywhere #36319 (comment) : IsDeviceTypeOnEndpoint logic is repeated in several places. Some code re-use would be nice.DataModel::Provider
everywhere #36319 (comment) :reporting/Read.cpp
is not ideally named, should be maybe inline into reporting or we should figure out proper naming and placementDataModel::Provider
everywhere #36319 (comment) : mLastSuccessfullyWrittenPath and mProcessingAttributePath are tightly coupled so we may be able to save some code/logic/flash/ram. Review their use and coupling and update the code accordinglyThe text was updated successfully, but these errors were encountered: