Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup code cleanup/optmization after #36319 #36327

Open
2 of 3 tasks
andy31415 opened this issue Oct 31, 2024 · 1 comment
Open
2 of 3 tasks

Followup code cleanup/optmization after #36319 #36327

andy31415 opened this issue Oct 31, 2024 · 1 comment

Comments

@andy31415
Copy link
Contributor

andy31415 commented Oct 31, 2024

Once we have a single codepath, some optimizations become clearer:

@andy31415
Copy link
Contributor Author

For the 3rd item, I could not find an immediate dedup logic for mLastSuccessfullyWrittenPath and mProcessingAttributePath as their code paths are updated at separate times. Deduplicating members within our handlers will likely require separate consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant