Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ReadHandler] ReadHandler makes ICD wake up twice for reports #27672

Closed
lpbeliveau-silabs opened this issue Jul 6, 2023 · 2 comments · Fixed by #28104
Closed

[ReadHandler] ReadHandler makes ICD wake up twice for reports #27672

lpbeliveau-silabs opened this issue Jul 6, 2023 · 2 comments · Fixed by #28104
Assignees
@lpbeliveau-silabs
Labels
icd Intermittently Connected Devices
Milestone
1.2

Comments

@lpbeliveau-silabs
Copy link
Contributor

The current ReadHandler logic makes devices wake up on min interval just to clear the WaitingForMinInterval flag regardless of if a report should be scheduled or not on that timeout.

The logic needs to be changed to prevent un-necessary wake-ups in ICD.
@lpbeliveau-silabs lpbeliveau-silabs self-assigned this Jul 6, 2023
@lpbeliveau-silabs
Copy link
Contributor Author

lpbeliveau-silabs commented Jul 6, 2023 •
edited
Loading

To accomplish this, the timing logic will be extracted from the ReadHandlers and moved into a separate object : ReportScheduler.

@lpbeliveau-silabs
Copy link
Contributor Author

See #27553

@lpbeliveau-silabs lpbeliveau-silabs added the icd Intermittently Connected Devices label Jul 18, 2023
@mkardous-silabs mkardous-silabs added this to the 1.2 milestone Jul 18, 2023
@mkardous-silabs mkardous-silabs mentioned this issue Jul 20, 2023
Merged
@mergify mergify bot closed this as completed in #28104 Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lpbeliveau-silabs lpbeliveau-silabs

Labels
icd Intermittently Connected Devices
Projects
[Feature] Intermittently Connected Devices (ICD)
Status: Done
Milestone
1.2
2 participants
@mkardous-silabs @lpbeliveau-silabs