[BUG] Identify cluster effect identifier and effect variant are NOT the same thing - used in multiple example apps

[fessehaeve]

Reproduction steps

All the below mentioned example codes do casting from effect variant to effect identifier, which are not the same thing.

sIdentifyEffect = static_cast<EmberAfIdentifyEffectIdentifier>(identify->mEffectVariant);

examples/chef/efr32/src/AppTask.cpp
examples/light-switch-app/silabs/efr32/src/AppTask.cpp
examples/lighting-app/qpg/src/AppTask.cpp
examples/lighting-app/silabs/efr32/src/AppTask.cpp
examples/lock-app/qpg/src/AppTask.cpp
examples/lock-app/silabs/efr32/src/AppTask.cpp
examples/thermostat/silabs/efr32/src/AppTask.cpp
examples/window-app/common/src/WindowApp.cpp

Bug prevalence

always

GitHub hash of the SDK that was being used

e022057

Platform

efr32, other

Platform Version(s)

No response

Anything else?

No response

[bzbarsky-apple]

@mkardous-silabs Any idea what's going on here?

[mkardous-silabs]

It's been a while since i've played with the identify sutff. I would need to look into it.

[jmartinez-silabs]

@bzbarsky-apple Must be a copy mistake that got copied a bunch of times. I believe I am at fault for that initial commit. I'll fix that, It is clearly not what I meant there. I can change it for other platforms too

[bzbarsky-apple]

@jmartinez-silabs Thank you!