Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatterTvCastingBridge should probably stop using zzz_generated/darwin bits #26697

Closed
bzbarsky-apple opened this issue May 19, 2023 · 1 comment · Fixed by #26762
Closed

MatterTvCastingBridge should probably stop using zzz_generated/darwin bits #26697

bzbarsky-apple opened this issue May 19, 2023 · 1 comment · Fixed by #26762
Assignees
Labels
tv TV-related features

Comments

@bzbarsky-apple
Copy link
Contributor

zzz_generated/darwin/controller-clusters/zap-generated (added to the include path in examples/tv-casting-app/darwin/MatterTvCastingBridge/MatterTvCastingBridge.xcodeproj/project.pbxproj) contains the following files:

  • CHIPClientCallbacks.h -- not actually included in anything involved in MatterTvCastingBridge, I expect
  • CHIPClusters.h -- not sure, but can be replaced with non-generated CHIPCluster.h and using ClusterBase
  • IMClusterCommandHandler.cpp -- I expect not used in MatterTvCastingBridge, but not sure
  • access.h -- Since no server clusters are defined in controller-clusters.zap, this file as it's included now defines no non-default access (i.e. all reads need View, all writes/commands need Operate no matter what attribute/command is involved). If that default access is OK for MatterTvCastingBridge and then it can either use an empty access.h or use a mechanism similar to what Stop using app-specific codegen in Darwin framework builds. #26669 is doing to not even include the file. If the default is not OK, then this needs to be figured out in terms of what actual access policies this is trying to use.
  • endpoint_config.h -- There are no server clusters in controller-clusters.zap, so this could just be an empty file.
  • gen_config.h -- I really doubt anything from here is used in MatterTvCastingBridge; could just be an empty file.
@bzbarsky-apple bzbarsky-apple added the tv TV-related features label May 19, 2023
@bzbarsky-apple
Copy link
Contributor Author

@lazarkov @chrisdecenzo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tv TV-related features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants