-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Refactor subscription timer logic to send all updates at the same time #25085
Comments
The logic is implemented and integrated by: However, the crossfabric synchronisation fails the TestReadInteraction unit test as this test does not expect this behavior. |
WG: Is the TestReadInteraction failure due to implementation error or test design error? @jmartinez-silabs to follow up on details |
@turon Test design error, TestReadInteraction has test cases where multiple read handlers are expected to generate different reports at different times. For instance, Granted, it is currently disabled for icd devices but we are still not testing the syncrhonized behavior in any test. |
I'm assuming our design emits the emergency event at the min interval, but bundles in the non emergency information as well and that extra info is triggering the fail? How difficult will it be for the certification/test team to relax the pass criteria and update the harness for this? |
Update : TestReadInteraction now supports the Synchronized Report Scheduler since: #30608 was merged. Currently we have #31134 documenting the logic behind the synchronisation scheduling that needs to be review. We should close this issue once the documenting PR is merged unless a change in the synchronisation logic is deemed necessary. |
Feature description
For ICDs, it is preferable to wake up once to send all updates at the same time instead of waking up multiple times. The subscription logic needs to be refactored to allow for cross-fabric synchronization.
The text was updated successfully, but these errors were encountered: