Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TriggerImmediateQuery does not set mLastProvider (GenericOTARequestorDriver) #15974

Closed
harsha-rajendran opened this issue Mar 8, 2022 · 0 comments · Fixed by #16088
Closed
Assignees

Comments

@harsha-rajendran
Copy link
Contributor

Problem

OTARequestor::TriggerImmediateQuery() does not set the mLastUsedProvider (part of the GenericOTARequestorDriver), before triggering a QueryImage. This might result in the same provider being used for the next OTA "re-attempt".

Proposed Solution

Update the mLastUsedProvider in the OTARequestorDriverSendQueryImage(), perhaps? Doing this might be out of the function scope, however, so another option might be to add a new pre-SendImageQuery() in the driver?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants