Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align lock-app/nrfconnect with #14551 #15156

Closed
msandstedt opened this issue Feb 14, 2022 · 3 comments
Closed

align lock-app/nrfconnect with #14551 #15156

msandstedt opened this issue Feb 14, 2022 · 3 comments
Assignees

Comments

@msandstedt
Copy link
Contributor

Problem

#14551 introduces VID / PID check during attestation. This means that devices must align their advertised VID/PID with their DAC, which in most or all cases will be an example DAC.

Right now, this example has:

I: 441 [DL]  Vendor Id: 9050 (0x235A)
I: 445 [DL]  Product Id: 20043 (0x4E4B)

Proposed Solution

To match the example DAC, Vendor ID must instead be 0xFFF1 and Product ID must be in the allowable range 0x8000-0x801F.

@Damian-Nordic
Copy link
Contributor

Which version was this tested on? 482e6fd fixed nrfconnect examples, too and I tested on the ToT lock-app that everything looks fine:

I: 454 [DL]  Vendor Id: 65521 (0xFFF1)
I: 458 [DL]  Product Id: 32774 (0x8006)

@Damian-Nordic
Copy link
Contributor

Only lighting-app had a wrong PID set, so fixed that in #15195.

@msandstedt
Copy link
Contributor Author

@Damian-Nordic ,

Thanks, yes this is now working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants