Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for software version handling in OTA Requestor #13604

Closed
carol-apple opened this issue Jan 14, 2022 · 2 comments
Closed

Add support for software version handling in OTA Requestor #13604

carol-apple opened this issue Jan 14, 2022 · 2 comments
Assignees
Labels

Comments

@carol-apple
Copy link
Contributor

Problem

OTA Requestor needs to do various things with the software version it is updating to. A few examples:

    1. During QueryImageResponse, if the software version supplied is the same as current version, ignore and do not proceed - refer to 11.20.3.2. Querying the OTA Provider
    1. After a software update has been applied successfully, the software version should be updated in the OTA Requestor core as well as the Basic clusters SoftwareVersion attribute (the OTA Requestor core should keep this value to support (1) above)

Proposed Solution

Add the following to OTARequestorInterface:

  • States for the current version vs target version (the new version that provider wants to supply)
  • Logic to determine when to ignore an image when QueryImageResponse is received
  • New API in OTARequestorInterface to update the software version when necessary (like after a successful apply)
  • Maybe in the new API introduced above, it should call Basic::Attributes::SoftwareVersion::Set

The new API should be called by various implementations of OTA after an Apply has succeeded. For instance, in Linux, the OTAImageProcessorImpl::Apply is a no op and should call the new API directly from there with the software version it obtained maybe from the image header. For other platforms, this new API should be called after restarting the app.

@dhrishi
Copy link
Contributor

dhrishi commented Jan 20, 2022

@jadhavrohit924 PTAL

@dhrishi
Copy link
Contributor

dhrishi commented Jan 27, 2022

i. has been addressed and merged in #13742
ii. updating Basic cluster attributes now no longer belongs in OTA logic

@dhrishi dhrishi closed this as completed Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants