Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to OTARequestorDriver used to report error condictions #12775

Closed
todo bot opened this issue Dec 9, 2021 · 1 comment
Closed

Add a method to OTARequestorDriver used to report error condictions #12775

todo bot opened this issue Dec 9, 2021 · 1 comment
Assignees

Comments

@todo
Copy link

todo bot commented Dec 9, 2021

// TODO: Add a method to OTARequestorDriver used to report error condictions
VerifyOrReturn(response.imageURI.HasValue(), ChipLogError(SoftwareUpdate, "Update is available but no image URI present"));
// Parse out the provider node ID and file designator from the image URI
NodeId nodeId = kUndefinedNodeId;
char fileDesignatorBuffer[kUriMaxLen] = { 0 };
MutableCharSpan fileDesignator(fileDesignatorBuffer, kUriMaxLen);
CHIP_ERROR err = requestorCore->mBdxDownloader->ParseBdxUri(response.imageURI.Value(), nodeId, fileDesignator);
VerifyOrReturn(err == CHIP_NO_ERROR,
ChipLogError(SoftwareUpdate, "Parse BDX image URI (%.*s) returned err=%" CHIP_ERROR_FORMAT,
static_cast<int>(response.imageURI.Value().size()), response.imageURI.Value().data(),


This issue was generated by todo based on a TODO comment in a3127d8 when #12636 was merged. cc @carol-apple.
@todo todo bot added the todo label Dec 9, 2021
@carol-apple carol-apple removed the todo label Dec 10, 2021
@carol-apple
Copy link
Contributor

Fixed by #13210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant