Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this will cause problems if Finalize() is not guaranteed to do its work after Pr... #12589

Closed
todo bot opened this issue Dec 4, 2021 · 1 comment
Closed
Assignees
Labels

Comments

@todo
Copy link

todo bot commented Dec 4, 2021

// TODO: this will cause problems if Finalize() is not guaranteed to do its work after ProcessBlock().
if (outEvent.blockdata.IsEof)
{
mBdxTransfer.PrepareBlockAck();
ReturnErrorOnFailure(mImageProcessor->Finalize());
}
break;
}
case TransferSession::OutputEventType::kStatusReceived:
ChipLogError(BDX, "BDX StatusReport %x", static_cast<uint16_t>(outEvent.statusData.statusCode));


This issue was generated by todo based on a TODO comment in 8cdc8fb when #12560 was merged. cc @holbrookt.
@todo todo bot added the todo label Dec 4, 2021
@todo todo bot assigned holbrookt Dec 4, 2021
@carol-apple
Copy link
Contributor

Closing, dupe of #12602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants