Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize OTA Requestor API #11742

Closed
selissia opened this issue Nov 12, 2021 · 4 comments
Closed

Finalize OTA Requestor API #11742

selissia opened this issue Nov 12, 2021 · 4 comments
Labels
feature work p1 priority 1 work

Comments

@selissia
Copy link
Contributor

Problem

The platform and application OTARequestor API needs to be much more extensive than it currently is.

Proposed Solution

Collect, evaluate the already existing API proposals and if deemed viable add the corresponding declarations.

Several proposals are given here: #11605

@selissia
Copy link
Contributor Author

selissia commented Dec 2, 2021

Links to specific proposals:
#11605 (comment)
#11605 (comment)

@selissia
Copy link
Contributor Author

selissia commented Dec 2, 2021

Comment:

src/app/clusters/ota-requestor/ota-downloader.h
// Platform calls this method upon the completion of ProcessBlock() processing
void virtual OnBlockProcessed(BlockActionType action);

Contributor
@shubhamdp shubhamdp 20 days ago
In case if error occurs during the block processing, should there be some status which tells why the processing failed along with the action?

For this we'll need to dd "error" enum value for BlockActionType

@selissia
Copy link
Contributor Author

selissia commented Dec 2, 2021

Comment:

src/app/clusters/ota-requestor/ota-image-processor.h
class OTAImageProcessorDriver
{
public:
// Open file, find block of space in persistent memory, or allocate a buffer, etc.

Contributor
@shubhamdp shubhamdp 20 days ago
Would it help if we have an option to resume the download?

@selissia
Copy link
Contributor Author

Additional APIs declared in #12755 . No more API work will be done for TE-7.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature work p1 priority 1 work
Projects
None yet
Development

No branches or pull requests

1 participant