Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use symbolic names for TLV tags in CASE #10091

Open
bzbarsky-apple opened this issue Sep 30, 2021 · 5 comments · May be fixed by #36679
Open

Use symbolic names for TLV tags in CASE #10091

bzbarsky-apple opened this issue Sep 30, 2021 · 5 comments · May be fixed by #36679
Labels
V1.X

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

We have symbolic names for the tags in ParseSigma1 (after #10084) but not other places in the file.

Proposed Solution

Use symbolic names throughout, for both encoding and decoding.
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 30, 2021
Merged
@woody-apple woody-apple added spec Mismatch between spec and implementation V1.0 labels Jan 25, 2022
@andy31415 andy31415 added v1_triage_split_12 V1.0 spec Mismatch between spec and implementation and removed V1.0 spec Mismatch between spec and implementation labels Jan 30, 2022
@woody-apple woody-apple added V1.X and removed V1.0 spec Mismatch between spec and implementation labels Feb 8, 2022
@woody-apple
Copy link
Contributor

Doesn't appear to have user impact, moving to post V1.0

@stale
Copy link

stale bot commented Aug 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Aug 12, 2022
@stale
Copy link

stale bot commented Oct 9, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Oct 9, 2022
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Oct 10, 2022
@stale
Copy link

stale bot commented Apr 11, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Apr 11, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Apr 11, 2023
@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Oct 15, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Oct 16, 2023
@Alami-Amine Alami-Amine linked a pull request Dec 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
V1.X
Projects
None yet
Milestone
No milestone
4 participants
@andy31415 @lzgrablic02 @woody-apple @bzbarsky-apple