address comments

yunhanw-google · yunhanw-google · commit f721a99f8d92 · 2024-05-23T13:28:49.000-07:00
diff --git a/src/controller/AutoCommissioner.cpp b/src/controller/AutoCommissioner.cpp
@@ -125,6 +125,8 @@ CHIP_ERROR AutoCommissioner::SetCommissioningParameters(const CommissioningParam
 
     mParams = params;
 
+    mNeedIcdRegistration = false;
+
     if (haveMaybeDanglingBufferPointers)
     {
         mParams.ClearExternalBufferDependentValues();
@@ -760,7 +762,6 @@ CHIP_ERROR AutoCommissioner::CommissioningStepFinished(CHIP_ERROR err, Commissio
                 }
             }
 
-            mNeedIcdRegistration = false;
             if (mParams.GetICDRegistrationStrategy() != ICDRegistrationStrategy::kIgnore)
             {
                 if (mDeviceCommissioningInfo.icd.isLIT && mDeviceCommissioningInfo.icd.checkInProtocolSupport)

Original file line number	Diff line number	Diff line change
`@@ -125,6 +125,8 @@ CHIP_ERROR AutoCommissioner::SetCommissioningParameters(const CommissioningParam`
`125`	`125`
`126`	`126`	`mParams = params;`
`127`	`127`
	`128`	`+ mNeedIcdRegistration = false;`
	`129`	`+`
`128`	`130`	`if (haveMaybeDanglingBufferPointers)`
`129`	`131`	`{`
`130`	`132`	`mParams.ClearExternalBufferDependentValues();`
`@@ -760,7 +762,6 @@ CHIP_ERROR AutoCommissioner::CommissioningStepFinished(CHIP_ERROR err, Commissio`
`760`	`762`	`}`
`761`	`763`	`}`
`762`	`764`
`763`		`- mNeedIcdRegistration = false;`
`764`	`765`	`if (mParams.GetICDRegistrationStrategy() != ICDRegistrationStrategy::kIgnore)`
`765`	`766`	`{`
`766`	`767`	`if (mDeviceCommissioningInfo.icd.isLIT && mDeviceCommissioningInfo.icd.checkInProtocolSupport)`