Update optional parameters of Step command and matched spec naming. Improved checking on Auto feature when receiving smart mode.

Author: mhazley

examples/all-clusters-app/all-clusters-common/all-clusters-app.matter

@@ -3233,8 +3233,8 @@ server cluster FanControl = 514 {
 
   request struct StepRequest {
     DirectionEnum direction = 0;
-    boolean wrap = 1;
-    boolean lowestOff = 2;
+    optional boolean wrap = 1;
+    optional boolean lowestOff = 2;
   }
 
   command Step(StepRequest): DefaultSuccess = 0;

examples/chef/devices/rootnode_thermostat_bm3fb8dhYi.matter

@@ -1333,8 +1333,8 @@ client cluster FanControl = 514 {
 
   request struct StepRequest {
     DirectionEnum direction = 0;
-    boolean wrap = 1;
-    boolean lowestOff = 2;
+    optional boolean wrap = 1;
+    optional boolean lowestOff = 2;
   }
 
   /** The Step command speeds up or slows down the fan, in steps. */

src/app/clusters/fan-control-server/fan-control-server.cpp

@@ -125,8 +125,9 @@ MatterFanControlClusterServerPreAttributeChangedCallback(const ConcreteAttribute
         {
             FanModeSequenceType fanModeSequence;
             FanModeSequence::Get(attributePath.mEndpointId, &fanModeSequence);
-            if ((fanModeSequence == FanModeSequenceType::kOffLowHighAuto) ||
-                (fanModeSequence == FanModeSequenceType::kOffLowMedHighAuto))
+            if (SupportsAuto(attributePath.mEndpointId) &&
+                ((fanModeSequence == FanModeSequenceType::kOffLowHighAuto) ||
+                 (fanModeSequence == FanModeSequenceType::kOffLowMedHighAuto)))
             {
                 *value = static_cast<uint8_t>(FanModeType::kAuto);
             }

src/app/zap-templates/zcl/data-model/chip/fan-control-cluster.xml

@@ -24,7 +24,7 @@ limitations under the License.
     <field name="Rocking" mask="0x04" />
     <field name="Wind" mask="0x08" />
     <field name="Step" mask="0x10" />
-    <field name="Airflow-Direction" mask="0x20" />
+    <field name="Airflow Direction" mask="0x20" />
   </bitmap>
 
   <enum name="FanModeType" type="ENUM8">
@@ -105,8 +105,8 @@ limitations under the License.
     <command source="client" code="0x00" name="Step" optional="true">
       <description>The Step command speeds up or slows down the fan, in steps.</description>
       <arg name="Direction" type="DirectionEnum"/>
-      <arg name="Wrap" type="boolean"/>
-      <arg name="LowestOff" type="boolean"/>
+      <arg name="Wrap" type="boolean" optional="true"/>
+      <arg name="LowestOff" type="boolean" optional="true"/>
     </command>
 
   </cluster>

src/controller/data_model/controller-clusters.matter

@@ -3603,8 +3603,8 @@ client cluster FanControl = 514 {
 
   request struct StepRequest {
     DirectionEnum direction = 0;
-    boolean wrap = 1;
-    boolean lowestOff = 2;
+    optional boolean wrap = 1;
+    optional boolean lowestOff = 2;
   }
 
   /** The Step command speeds up or slows down the fan, in steps. */