From b87244d1c82e6de6e516d78e7c002926b95f4549 Mon Sep 17 00:00:00 2001 From: Evgeny Margolis Date: Thu, 21 Jul 2022 11:28:35 -0700 Subject: [PATCH] Remove Obsolete TODOs in the AddTrustedRootCertificate and AddNOC Commands. (#21060) --- .../operational-credentials-server.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/app/clusters/operational-credentials-server/operational-credentials-server.cpp b/src/app/clusters/operational-credentials-server/operational-credentials-server.cpp index ce29aaea9c5fb1..35c4ec99e4ccd3 100644 --- a/src/app/clusters/operational-credentials-server/operational-credentials-server.cpp +++ b/src/app/clusters/operational-credentials-server/operational-credentials-server.cpp @@ -668,9 +668,6 @@ bool emberAfOperationalCredentialsClusterAddNOCCallback(app::CommandHandler * co // Flush acks before really slow work commandObj->FlushAcksRightAwayOnSlowCommand(); - // TODO: Add support for calling AddNOC without a prior AddTrustedRootCertificate if - // the root properly matches an existing one. - // We can't possibly have a matching root based on the fact that we don't have // a shared root store. Therefore we would later fail path validation due to // missing root. Let's early-bail with InvalidNOC. @@ -1197,8 +1194,6 @@ bool emberAfOperationalCredentialsClusterAddTrustedRootCertificateCallback( // Flush acks before really slow work commandObj->FlushAcksRightAwayOnSlowCommand(); - // TODO(#17208): Handle checking for byte-to-byte match with existing fabrics before allowing the add - err = ValidateChipRCAC(rootCertificate); VerifyOrExit(err == CHIP_NO_ERROR, finalStatus = Status::InvalidCommand);