Skip to content

Commit 5959425

Browse files
ericzijian1994hare-siterwell
authored andcommitted
[SMOKECO-TC] Fix smokeco tests as per test plan document (#29701)
* Add SMOKECO.M.ManuallyControlledTest PICS * Add top-level PICS * Change top-level PICS --------- Co-authored-by: Hare <[email protected]>
1 parent 1df5d3f commit 5959425

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

src/app/tests/suites/certification/Test_TC_SMOKECO_2_2.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ name:
1717
Server
1818

1919
PICS:
20-
- SMOKECO.S
20+
- SMOKECO.S.F00
2121

2222
config:
2323
nodeId: 0x12344321
@@ -145,7 +145,7 @@ tests:
145145
value: "y"
146146

147147
- label: "Step 10: TH reads TestInProgress attribute from DUT"
148-
PICS: SMOKECO.S.A0005
148+
PICS: SMOKECO.S.A0005 && SMOKECO.M.ManuallyControlledTest
149149
command: "readAttribute"
150150
attribute: "TestInProgress"
151151
response:

src/app/tests/suites/certification/Test_TC_SMOKECO_2_3.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ name:
1616
4.2.3. [TC-SMOKECO-2.3] Primary Functionality - CO Alarm with DUT as Server
1717

1818
PICS:
19-
- SMOKECO.S
19+
- SMOKECO.S.F01
2020

2121
config:
2222
nodeId: 0x12344321
@@ -144,7 +144,7 @@ tests:
144144
value: "y"
145145

146146
- label: "Step 10: TH reads TestInProgress attribute from DUT"
147-
PICS: SMOKECO.S.A0005
147+
PICS: SMOKECO.S.A0005 && SMOKECO.M.ManuallyControlledTest
148148
command: "readAttribute"
149149
attribute: "TestInProgress"
150150
response:

src/app/tests/suites/certification/Test_TC_SMOKECO_2_4.yaml

+6-6
Original file line numberDiff line numberDiff line change
@@ -511,7 +511,7 @@ tests:
511511
- label:
512512
"Step 38: TH waits for a report of TestInProgress attribute from DUT
513513
with a timeout of 180 seconds"
514-
PICS: SMOKECO.S.A0005
514+
PICS: SMOKECO.S.A0005 && SMOKECO.M.ManuallyControlledTest
515515
command: "waitForReport"
516516
attribute: "TestInProgress"
517517
timeout: 180
@@ -521,7 +521,7 @@ tests:
521521
type: boolean
522522

523523
- label: "Step 39: TH reads ExpressedState attribute from DUT"
524-
PICS: SMOKECO.S.A0000
524+
PICS: SMOKECO.S.A0000 && SMOKECO.M.ManuallyControlledTest
525525
command: "readAttribute"
526526
attribute: "ExpressedState"
527527
response:
@@ -532,7 +532,7 @@ tests:
532532
- label:
533533
"Step 40: TH waits for a report of TestInProgress attribute from DUT
534534
with a timeout of 180 seconds"
535-
PICS: SMOKECO.S.A0005
535+
PICS: SMOKECO.S.A0005 && SMOKECO.M.ManuallyControlledTest
536536
command: "waitForReport"
537537
attribute: "TestInProgress"
538538
timeout: 180
@@ -542,15 +542,15 @@ tests:
542542
type: boolean
543543

544544
- label: "Step 41: TH reads SelfTestComplete event from DUT"
545-
PICS: SMOKECO.S.E05
545+
PICS: SMOKECO.S.E05 && SMOKECO.M.ManuallyControlledTest
546546
command: "readEvent"
547547
event: "SelfTestComplete"
548548
eventNumber: "LastReceivedEventNumber + 1"
549549
response:
550550
value: {}
551551

552552
- label: "Step 42: TH reads ExpressedState attribute from DUT"
553-
PICS: SMOKECO.S.A0000
553+
PICS: SMOKECO.S.A0000 && SMOKECO.M.ManuallyControlledTest
554554
command: "readAttribute"
555555
attribute: "ExpressedState"
556556
response:
@@ -559,7 +559,7 @@ tests:
559559
type: enum8
560560

561561
- label: "Step 43: TH reads AllClear event from DUT"
562-
PICS: SMOKECO.S.E0a
562+
PICS: SMOKECO.S.E0a && SMOKECO.M.ManuallyControlledTest
563563
command: "readEvent"
564564
event: "AllClear"
565565
eventNumber: "LastReceivedEventNumber + 1"

0 commit comments

Comments
 (0)