Skip to content

Commit 5279457

Browse files
bzbarsky-applepull[bot]
authored andcommitted
Increase the timer slack TestRead allows to 100ms. (#27443)
We're polling until a timer fires, but due to other threads losing the timeslice for a while we could decide it's not firing when it's just been blocked on the scheduler. To reduce the risk of that, give it a bit more time to fire. Fixes #27438
1 parent 3e77db7 commit 5279457

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/controller/tests/data_model/TestRead.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -4645,14 +4645,14 @@ void TestReadInteraction::TestReadHandler_KeepSubscriptionTest(nlTestSuite * apS
46454645

46464646
System::Clock::Timeout TestReadInteraction::ComputeSubscriptionTimeout(System::Clock::Seconds16 aMaxInterval)
46474647
{
4648-
// Add 50ms of slack to our max interval to make sure we hit the
4648+
// Add 100ms of slack to our max interval to make sure we hit the
46494649
// subscription liveness timer.
46504650
const auto & ourMrpConfig = GetDefaultMRPConfig();
46514651
auto publisherTransmissionTimeout =
46524652
GetRetransmissionTimeout(ourMrpConfig.mActiveRetransTimeout, ourMrpConfig.mIdleRetransTimeout,
46534653
System::SystemClock().GetMonotonicTimestamp(), Transport::kMinActiveTime);
46544654

4655-
return publisherTransmissionTimeout + aMaxInterval + System::Clock::Milliseconds32(50);
4655+
return publisherTransmissionTimeout + aMaxInterval + System::Clock::Milliseconds32(100);
46564656
}
46574657

46584658
// clang-format off

0 commit comments

Comments
 (0)