Skip to content

Commit 4712291

Browse files
vivien-applepull[bot]
authored andcommitted
[cluster] Move ColorControl cluster to a dedicated file (#24727)
1 parent 128b390 commit 4712291

File tree

10 files changed

+494
-440
lines changed

10 files changed

+494
-440
lines changed

.github/workflows/tests.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@ jobs:
125125
src/app/zap-templates/zcl/data-model/chip/chip-types.xml \
126126
src/app/zap-templates/zcl/data-model/chip/channel-cluster.xml \
127127
src/app/zap-templates/zcl/data-model/chip/clusters-extensions.xml \
128+
src/app/zap-templates/zcl/data-model/chip/color-control-cluster.xml \
128129
src/app/zap-templates/zcl/data-model/chip/content-launch-cluster.xml \
129130
src/app/zap-templates/zcl/data-model/chip/descriptor-cluster.xml \
130131
src/app/zap-templates/zcl/data-model/chip/diagnostic-logs-cluster.xml \
@@ -182,7 +183,6 @@ jobs:
182183
src/app/zap-templates/zcl/data-model/silabs/lo-devices.xml \
183184
src/app/zap-templates/zcl/data-model/silabs/types-silabs.xml \
184185
src/app/zap-templates/zcl/data-model/silabs/zll-devices.xml \
185-
src/app/zap-templates/zcl/data-model/silabs/zll.xml \
186186
"
187187
- name: Build Apps
188188
timeout-minutes: 60

scripts/rules.matterlint

+1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ load "../src/app/zap-templates/zcl/data-model/chip/channel-cluster.xml";
1717
load "../src/app/zap-templates/zcl/data-model/chip/chip-ota.xml";
1818
load "../src/app/zap-templates/zcl/data-model/chip/chip-types.xml";
1919
load "../src/app/zap-templates/zcl/data-model/chip/clusters-extensions.xml";
20+
load "../src/app/zap-templates/zcl/data-model/chip/color-control-cluster.xml";
2021
load "../src/app/zap-templates/zcl/data-model/chip/content-launch-cluster.xml";
2122
load "../src/app/zap-templates/zcl/data-model/chip/descriptor-cluster.xml";
2223
load "../src/app/zap-templates/zcl/data-model/chip/diagnostic-logs-cluster.xml";

src/app/zap-templates/zcl/data-model/all.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
<xi:include href="chip/chip-types.xml" />
1616
<xi:include href="chip/client-monitoring-cluster.xml" />
1717
<xi:include href="chip/clusters-extensions.xml" />
18+
<xi:include href="chip/color-control-cluster.xml" />
1819
<xi:include href="chip/content-launch-cluster.xml" />
1920
<xi:include href="chip/descriptor-cluster.xml" />
2021
<xi:include href="chip/diagnostic-logs-cluster.xml" />
@@ -72,5 +73,4 @@
7273
<xi:include href="silabs/lo-devices.xml" />
7374
<xi:include href="silabs/types-silabs.xml" />
7475
<xi:include href="silabs/zll-devices.xml" />
75-
<xi:include href="silabs/zll.xml" />
7676
</all>

src/app/zap-templates/zcl/data-model/chip/color-control-cluster.xml

+459
Large diffs are not rendered by default.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
<?xml version="1.0"?>
2+
<!--
3+
Copyright (c) 2023 Project CHIP Authors
4+
5+
Licensed under the Apache License, Version 2.0 (the "License");
6+
you may not use this file except in compliance with the License.
7+
You may obtain a copy of the License at
8+
9+
http://www.apache.org/licenses/LICENSE-2.0
10+
11+
Unless required by applicable law or agreed to in writing, software
12+
distributed under the License is distributed on an "AS IS" BASIS,
13+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
See the License for the specific language governing permissions and
15+
limitations under the License.
16+
-->
17+
<configurator>
18+
<enum name="ColorControlOptions" type="BITMAP8">
19+
<item name="ExecuteIfOff" value="0x1"/>
20+
</enum>
21+
22+
<enum name="EnhancedColorMode" type="ENUM8">
23+
<item name="CurrentHueAndCurrentSaturation" value="0x00"/>
24+
<item name="CurrentXAndCurrentY" value="0x01"/>
25+
<item name="ColorTemperature" value="0x02"/>
26+
<item name="EnhancedCurrentHueAndCurrentSaturation" value="0x03"/>
27+
</enum>
28+
</configurator>

src/app/zap-templates/zcl/data-model/silabs/ha.xml

-253
Large diffs are not rendered by default.

src/app/zap-templates/zcl/data-model/silabs/types-silabs.xml

-38
Original file line numberDiff line numberDiff line change
@@ -159,44 +159,6 @@ limitations under the License.
159159
<item name="levelFourLockout" value="0x4"/>
160160
<item name="levelfiveLockout" value="0x5"/>
161161
</enum>
162-
<enum name="HueDirection" type="ENUM8">
163-
<cluster code="0x0300"/>
164-
<item name="ShortestDistance" value="0x0"/>
165-
<item name="LongestDistance" value="0x1"/>
166-
<item name="Up" value="0x2"/>
167-
<item name="Down" value="0x3"/>
168-
</enum>
169-
<enum name="HueMoveMode" type="ENUM8">
170-
<cluster code="0x0300"/>
171-
<item name="Stop" value="0x0"/>
172-
<item name="Up" value="0x1"/>
173-
<item name="Down" value="0x3"/>
174-
</enum>
175-
<enum name="HueStepMode" type="ENUM8">
176-
<cluster code="0x0300"/>
177-
<item name="Up" value="0x1"/>
178-
<item name="Down" value="0x3"/>
179-
</enum>
180-
<enum name="SaturationMoveMode" type="ENUM8">
181-
<cluster code="0x0300"/>
182-
<item name="Stop" value="0x0"/>
183-
<item name="Up" value="0x1"/>
184-
<item name="Down" value="0x3"/>
185-
</enum>
186-
<enum name="SaturationStepMode" type="ENUM8">
187-
<cluster code="0x0300"/>
188-
<item name="Up" value="0x1"/>
189-
<item name="Down" value="0x3"/>
190-
</enum>
191-
<enum name="ColorMode" type="ENUM8">
192-
<cluster code="0x0300"/>
193-
<item name="CurrentHueAndCurrentSaturation" value="0x00"/>
194-
<item name="CurrentXAndCurrentY" value="0x01"/>
195-
<item name="ColorTemperature" value="0x02"/>
196-
</enum>
197-
<enum name="ColorControlOptions" type="BITMAP8">
198-
<item name="ExecuteIfOff" value="0x1"/>
199-
</enum>
200162
<enum name="LevelStatus" type="ENUM8">
201163
<item name="OnTarget" value="0x0"/>
202164
<item name="BelowTarget" value="0x1"/>

src/app/zap-templates/zcl/data-model/silabs/zll.xml

-145
This file was deleted.

src/app/zap-templates/zcl/zcl-with-test-extensions.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
"channel-cluster.xml",
3131
"client-monitoring-cluster.xml",
3232
"clusters-extensions.xml",
33+
"color-control-cluster.xml",
3334
"content-launch-cluster.xml",
3435
"descriptor-cluster.xml",
3536
"diagnostic-logs-cluster.xml",
@@ -86,7 +87,7 @@
8687
"ha.xml",
8788
"lo-devices.xml",
8889
"zll-devices.xml",
89-
"zll.xml"
90+
"types/color-control.xml"
9091
],
9192
"manufacturersXml": "../../../../src/app/zap-templates/zcl/data-model/manufacturers.xml",
9293
"options": {

src/app/zap-templates/zcl/zcl.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
"channel-cluster.xml",
3030
"client-monitoring-cluster.xml",
3131
"clusters-extensions.xml",
32+
"color-control-cluster.xml",
3233
"content-launch-cluster.xml",
3334
"descriptor-cluster.xml",
3435
"diagnostic-logs-cluster.xml",
@@ -84,7 +85,7 @@
8485
"ha.xml",
8586
"lo-devices.xml",
8687
"zll-devices.xml",
87-
"zll.xml"
88+
"types/color-control.xml"
8889
],
8990
"manufacturersXml": "../../../../src/app/zap-templates/zcl/data-model/manufacturers.xml",
9091
"options": {

0 commit comments

Comments
 (0)