Skip to content

Commit 4237395

Browse files
andy31415andreilitvin
authored andcommitted
Move OnOff cluster to match the spec (#29946)
* Match onoff naming to spec * Zap regen * Minor change to re-kick CI * Undo the rename of Behaviour * Bump OnOff revision to 6 (add off only feature) --------- Co-authored-by: Andrei Litvin <[email protected]>
1 parent 45f9a3f commit 4237395

File tree

42 files changed

+72
-26
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+72
-26
lines changed

examples/all-clusters-app/all-clusters-common/all-clusters-app.matter

+4-2
Original file line numberDiff line numberDiff line change
@@ -314,6 +314,7 @@ client cluster OnOff = 6 {
314314
bitmap Feature : bitmap32 {
315315
kLighting = 0x1;
316316
kDeadFrontBehavior = 0x2;
317+
kOffOnly = 0x4;
317318
}
318319

319320
bitmap OnOffControlBitmap : bitmap8 {
@@ -334,7 +335,7 @@ client cluster OnOff = 6 {
334335

335336
request struct OffWithEffectRequest {
336337
EffectIdentifierEnum effectIdentifier = 0;
337-
int8u effectVariant = 1;
338+
enum8 effectVariant = 1;
338339
}
339340

340341
request struct OnWithTimedOffRequest {
@@ -383,6 +384,7 @@ server cluster OnOff = 6 {
383384
bitmap Feature : bitmap32 {
384385
kLighting = 0x1;
385386
kDeadFrontBehavior = 0x2;
387+
kOffOnly = 0x4;
386388
}
387389

388390
bitmap OnOffControlBitmap : bitmap8 {
@@ -403,7 +405,7 @@ server cluster OnOff = 6 {
403405

404406
request struct OffWithEffectRequest {
405407
EffectIdentifierEnum effectIdentifier = 0;
406-
int8u effectVariant = 1;
408+
enum8 effectVariant = 1;
407409
}
408410

409411
request struct OnWithTimedOffRequest {

examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter

+2-1
Original file line numberDiff line numberDiff line change
@@ -269,6 +269,7 @@ server cluster OnOff = 6 {
269269
bitmap Feature : bitmap32 {
270270
kLighting = 0x1;
271271
kDeadFrontBehavior = 0x2;
272+
kOffOnly = 0x4;
272273
}
273274

274275
bitmap OnOffControlBitmap : bitmap8 {
@@ -289,7 +290,7 @@ server cluster OnOff = 6 {
289290

290291
request struct OffWithEffectRequest {
291292
EffectIdentifierEnum effectIdentifier = 0;
292-
int8u effectVariant = 1;
293+
enum8 effectVariant = 1;
293294
}
294295

295296
request struct OnWithTimedOffRequest {

examples/bridge-app/bridge-common/bridge-app.matter

+1
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ server cluster OnOff = 6 {
7373
bitmap Feature : bitmap32 {
7474
kLighting = 0x1;
7575
kDeadFrontBehavior = 0x2;
76+
kOffOnly = 0x4;
7677
}
7778

7879
bitmap OnOffControlBitmap : bitmap8 {

examples/chef/devices/noip_rootnode_dimmablelight_bCwGYSDpoe.matter

+1
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ server cluster OnOff = 6 {
136136
bitmap Feature : bitmap32 {
137137
kLighting = 0x1;
138138
kDeadFrontBehavior = 0x2;
139+
kOffOnly = 0x4;
139140
}
140141

141142
bitmap OnOffControlBitmap : bitmap8 {

examples/chef/devices/rootnode_basicvideoplayer_0ff86e943b.matter

+1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ server cluster OnOff = 6 {
2727
bitmap Feature : bitmap32 {
2828
kLighting = 0x1;
2929
kDeadFrontBehavior = 0x2;
30+
kOffOnly = 0x4;
3031
}
3132

3233
bitmap OnOffControlBitmap : bitmap8 {

examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.matter

+2-1
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ server cluster OnOff = 6 {
142142
bitmap Feature : bitmap32 {
143143
kLighting = 0x1;
144144
kDeadFrontBehavior = 0x2;
145+
kOffOnly = 0x4;
145146
}
146147

147148
bitmap OnOffControlBitmap : bitmap8 {
@@ -162,7 +163,7 @@ server cluster OnOff = 6 {
162163

163164
request struct OffWithEffectRequest {
164165
EffectIdentifierEnum effectIdentifier = 0;
165-
int8u effectVariant = 1;
166+
enum8 effectVariant = 1;
166167
}
167168

168169
request struct OnWithTimedOffRequest {

examples/chef/devices/rootnode_dimmablelight_bCwGYSDpoe.matter

+1
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ server cluster OnOff = 6 {
136136
bitmap Feature : bitmap32 {
137137
kLighting = 0x1;
138138
kDeadFrontBehavior = 0x2;
139+
kOffOnly = 0x4;
139140
}
140141

141142
bitmap OnOffControlBitmap : bitmap8 {

examples/chef/devices/rootnode_extendedcolorlight_8lcaaYJVAa.matter

+1
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ server cluster OnOff = 6 {
136136
bitmap Feature : bitmap32 {
137137
kLighting = 0x1;
138138
kDeadFrontBehavior = 0x2;
139+
kOffOnly = 0x4;
139140
}
140141

141142
bitmap OnOffControlBitmap : bitmap8 {

examples/chef/devices/rootnode_heatingcoolingunit_ncdGai1E5a.matter

+1
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ server cluster OnOff = 6 {
136136
bitmap Feature : bitmap32 {
137137
kLighting = 0x1;
138138
kDeadFrontBehavior = 0x2;
139+
kOffOnly = 0x4;
139140
}
140141

141142
bitmap OnOffControlBitmap : bitmap8 {

examples/chef/devices/rootnode_onofflight_bbs1b7IaOV.matter

+1
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ server cluster OnOff = 6 {
136136
bitmap Feature : bitmap32 {
137137
kLighting = 0x1;
138138
kDeadFrontBehavior = 0x2;
139+
kOffOnly = 0x4;
139140
}
140141

141142
bitmap OnOffControlBitmap : bitmap8 {

examples/chef/devices/rootnode_onofflight_samplemei.matter

+1
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ server cluster OnOff = 6 {
136136
bitmap Feature : bitmap32 {
137137
kLighting = 0x1;
138138
kDeadFrontBehavior = 0x2;
139+
kOffOnly = 0x4;
139140
}
140141

141142
bitmap OnOffControlBitmap : bitmap8 {

examples/chef/devices/rootnode_onofflightswitch_FsPlMr090Q.matter

+3-1
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ client cluster OnOff = 6 {
136136
bitmap Feature : bitmap32 {
137137
kLighting = 0x1;
138138
kDeadFrontBehavior = 0x2;
139+
kOffOnly = 0x4;
139140
}
140141

141142
bitmap OnOffControlBitmap : bitmap8 {
@@ -156,7 +157,7 @@ client cluster OnOff = 6 {
156157

157158
request struct OffWithEffectRequest {
158159
EffectIdentifierEnum effectIdentifier = 0;
159-
int8u effectVariant = 1;
160+
enum8 effectVariant = 1;
160161
}
161162

162163
request struct OnWithTimedOffRequest {
@@ -205,6 +206,7 @@ server cluster OnOff = 6 {
205206
bitmap Feature : bitmap32 {
206207
kLighting = 0x1;
207208
kDeadFrontBehavior = 0x2;
209+
kOffOnly = 0x4;
208210
}
209211

210212
bitmap OnOffControlBitmap : bitmap8 {

examples/chef/devices/rootnode_onoffpluginunit_Wtf8ss5EBY.matter

+1
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ server cluster OnOff = 6 {
136136
bitmap Feature : bitmap32 {
137137
kLighting = 0x1;
138138
kDeadFrontBehavior = 0x2;
139+
kOffOnly = 0x4;
139140
}
140141

141142
bitmap OnOffControlBitmap : bitmap8 {

examples/chef/devices/rootnode_pump_5f904818cc.matter

+1
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ server cluster OnOff = 6 {
7373
bitmap Feature : bitmap32 {
7474
kLighting = 0x1;
7575
kDeadFrontBehavior = 0x2;
76+
kOffOnly = 0x4;
7677
}
7778

7879
bitmap OnOffControlBitmap : bitmap8 {

examples/chef/devices/rootnode_pump_a811bb33a0.matter

+1
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ server cluster OnOff = 6 {
7373
bitmap Feature : bitmap32 {
7474
kLighting = 0x1;
7575
kDeadFrontBehavior = 0x2;
76+
kOffOnly = 0x4;
7677
}
7778

7879
bitmap OnOffControlBitmap : bitmap8 {

examples/chef/devices/rootnode_roomairconditioner_9cf3607804.matter

+1
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ server cluster OnOff = 6 {
142142
bitmap Feature : bitmap32 {
143143
kLighting = 0x1;
144144
kDeadFrontBehavior = 0x2;
145+
kOffOnly = 0x4;
145146
}
146147

147148
bitmap OnOffControlBitmap : bitmap8 {

examples/chef/devices/rootnode_speaker_RpzeXdimqA.matter

+1
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ server cluster OnOff = 6 {
6767
bitmap Feature : bitmap32 {
6868
kLighting = 0x1;
6969
kDeadFrontBehavior = 0x2;
70+
kOffOnly = 0x4;
7071
}
7172

7273
bitmap OnOffControlBitmap : bitmap8 {

examples/light-switch-app/light-switch-common/light-switch-app.matter

+2-1
Original file line numberDiff line numberDiff line change
@@ -372,6 +372,7 @@ client cluster OnOff = 6 {
372372
bitmap Feature : bitmap32 {
373373
kLighting = 0x1;
374374
kDeadFrontBehavior = 0x2;
375+
kOffOnly = 0x4;
375376
}
376377

377378
bitmap OnOffControlBitmap : bitmap8 {
@@ -392,7 +393,7 @@ client cluster OnOff = 6 {
392393

393394
request struct OffWithEffectRequest {
394395
EffectIdentifierEnum effectIdentifier = 0;
395-
int8u effectVariant = 1;
396+
enum8 effectVariant = 1;
396397
}
397398

398399
request struct OnWithTimedOffRequest {

examples/lighting-app/bouffalolab/data_model/lighting-app-ethernet.matter

+2-1
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ server cluster OnOff = 6 {
142142
bitmap Feature : bitmap32 {
143143
kLighting = 0x1;
144144
kDeadFrontBehavior = 0x2;
145+
kOffOnly = 0x4;
145146
}
146147

147148
bitmap OnOffControlBitmap : bitmap8 {
@@ -162,7 +163,7 @@ server cluster OnOff = 6 {
162163

163164
request struct OffWithEffectRequest {
164165
EffectIdentifierEnum effectIdentifier = 0;
165-
int8u effectVariant = 1;
166+
enum8 effectVariant = 1;
166167
}
167168

168169
request struct OnWithTimedOffRequest {

examples/lighting-app/bouffalolab/data_model/lighting-app-thread.matter

+2-1
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ server cluster OnOff = 6 {
142142
bitmap Feature : bitmap32 {
143143
kLighting = 0x1;
144144
kDeadFrontBehavior = 0x2;
145+
kOffOnly = 0x4;
145146
}
146147

147148
bitmap OnOffControlBitmap : bitmap8 {
@@ -162,7 +163,7 @@ server cluster OnOff = 6 {
162163

163164
request struct OffWithEffectRequest {
164165
EffectIdentifierEnum effectIdentifier = 0;
165-
int8u effectVariant = 1;
166+
enum8 effectVariant = 1;
166167
}
167168

168169
request struct OnWithTimedOffRequest {

examples/lighting-app/bouffalolab/data_model/lighting-app-wifi.matter

+2-1
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ server cluster OnOff = 6 {
142142
bitmap Feature : bitmap32 {
143143
kLighting = 0x1;
144144
kDeadFrontBehavior = 0x2;
145+
kOffOnly = 0x4;
145146
}
146147

147148
bitmap OnOffControlBitmap : bitmap8 {
@@ -162,7 +163,7 @@ server cluster OnOff = 6 {
162163

163164
request struct OffWithEffectRequest {
164165
EffectIdentifierEnum effectIdentifier = 0;
165-
int8u effectVariant = 1;
166+
enum8 effectVariant = 1;
166167
}
167168

168169
request struct OnWithTimedOffRequest {

examples/lighting-app/lighting-common/lighting-app.matter

+2-1
Original file line numberDiff line numberDiff line change
@@ -293,6 +293,7 @@ server cluster OnOff = 6 {
293293
bitmap Feature : bitmap32 {
294294
kLighting = 0x1;
295295
kDeadFrontBehavior = 0x2;
296+
kOffOnly = 0x4;
296297
}
297298

298299
bitmap OnOffControlBitmap : bitmap8 {
@@ -313,7 +314,7 @@ server cluster OnOff = 6 {
313314

314315
request struct OffWithEffectRequest {
315316
EffectIdentifierEnum effectIdentifier = 0;
316-
int8u effectVariant = 1;
317+
enum8 effectVariant = 1;
317318
}
318319

319320
request struct OnWithTimedOffRequest {

examples/lighting-app/nxp/zap/lighting-on-off.matter

+2-1
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ server cluster OnOff = 6 {
142142
bitmap Feature : bitmap32 {
143143
kLighting = 0x1;
144144
kDeadFrontBehavior = 0x2;
145+
kOffOnly = 0x4;
145146
}
146147

147148
bitmap OnOffControlBitmap : bitmap8 {
@@ -162,7 +163,7 @@ server cluster OnOff = 6 {
162163

163164
request struct OffWithEffectRequest {
164165
EffectIdentifierEnum effectIdentifier = 0;
165-
int8u effectVariant = 1;
166+
enum8 effectVariant = 1;
166167
}
167168

168169
request struct OnWithTimedOffRequest {

examples/lighting-app/qpg/zap/light.matter

+2-1
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ server cluster OnOff = 6 {
142142
bitmap Feature : bitmap32 {
143143
kLighting = 0x1;
144144
kDeadFrontBehavior = 0x2;
145+
kOffOnly = 0x4;
145146
}
146147

147148
bitmap OnOffControlBitmap : bitmap8 {
@@ -162,7 +163,7 @@ server cluster OnOff = 6 {
162163

163164
request struct OffWithEffectRequest {
164165
EffectIdentifierEnum effectIdentifier = 0;
165-
int8u effectVariant = 1;
166+
enum8 effectVariant = 1;
166167
}
167168

168169
request struct OnWithTimedOffRequest {

examples/lighting-app/silabs/data_model/lighting-thread-app.matter

+2-1
Original file line numberDiff line numberDiff line change
@@ -314,6 +314,7 @@ server cluster OnOff = 6 {
314314
bitmap Feature : bitmap32 {
315315
kLighting = 0x1;
316316
kDeadFrontBehavior = 0x2;
317+
kOffOnly = 0x4;
317318
}
318319

319320
bitmap OnOffControlBitmap : bitmap8 {
@@ -334,7 +335,7 @@ server cluster OnOff = 6 {
334335

335336
request struct OffWithEffectRequest {
336337
EffectIdentifierEnum effectIdentifier = 0;
337-
int8u effectVariant = 1;
338+
enum8 effectVariant = 1;
338339
}
339340

340341
request struct OnWithTimedOffRequest {

examples/lighting-app/silabs/data_model/lighting-wifi-app.matter

+2-1
Original file line numberDiff line numberDiff line change
@@ -293,6 +293,7 @@ server cluster OnOff = 6 {
293293
bitmap Feature : bitmap32 {
294294
kLighting = 0x1;
295295
kDeadFrontBehavior = 0x2;
296+
kOffOnly = 0x4;
296297
}
297298

298299
bitmap OnOffControlBitmap : bitmap8 {
@@ -313,7 +314,7 @@ server cluster OnOff = 6 {
313314

314315
request struct OffWithEffectRequest {
315316
EffectIdentifierEnum effectIdentifier = 0;
316-
int8u effectVariant = 1;
317+
enum8 effectVariant = 1;
317318
}
318319

319320
request struct OnWithTimedOffRequest {

examples/lock-app/lock-common/lock-app.matter

+1
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ server cluster OnOff = 6 {
7373
bitmap Feature : bitmap32 {
7474
kLighting = 0x1;
7575
kDeadFrontBehavior = 0x2;
76+
kOffOnly = 0x4;
7677
}
7778

7879
bitmap OnOffControlBitmap : bitmap8 {

examples/ota-requestor-app/ota-requestor-common/ota-requestor-app.matter

+2-1
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ server cluster OnOff = 6 {
142142
bitmap Feature : bitmap32 {
143143
kLighting = 0x1;
144144
kDeadFrontBehavior = 0x2;
145+
kOffOnly = 0x4;
145146
}
146147

147148
bitmap OnOffControlBitmap : bitmap8 {
@@ -162,7 +163,7 @@ server cluster OnOff = 6 {
162163

163164
request struct OffWithEffectRequest {
164165
EffectIdentifierEnum effectIdentifier = 0;
165-
int8u effectVariant = 1;
166+
enum8 effectVariant = 1;
166167
}
167168

168169
request struct OnWithTimedOffRequest {

0 commit comments

Comments
 (0)