Skip to content

Commit 4186931

Browse files
bzbarsky-applepull[bot]
authored andcommitted
Print framework log when framework build fails for darwin-frawework-tool. (#27862)
1 parent 74896f8 commit 4186931

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

scripts/build/build_darwin_framework.py

+9
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,15 @@ def run_command(command):
4545

4646
with open(args.log_path, "wb") as f:
4747
f.write(command_log)
48+
49+
if returncode != 0:
50+
# command_log is binary, so decoding as utf-8 might technically fail. We don't want
51+
# to throw on that.
52+
try:
53+
print("Failure log: {}".format(command_log.decode()))
54+
except Exception:
55+
pass
56+
4857
return returncode
4958

5059

0 commit comments

Comments
 (0)