Bugfix: Software-Version attribute is incorrectly being initialized with HardwareVersion default value (#11869)

jrhees-cae · pull[bot] · commit 3390008693fe · 2022-01-04T19:36:59.000Z
diff --git a/src/app/clusters/basic/basic.cpp b/src/app/clusters/basic/basic.cpp
@@ -87,7 +87,7 @@ void emberAfBasicClusterServerInitCallback(chip::EndpointId endpoint)
     uint16_t firmwareRevision;
     if (ConfigurationMgr().GetFirmwareRevision(firmwareRevision) == CHIP_NO_ERROR)
     {
-        status = Attributes::HardwareVersion::Set(endpoint, firmwareRevision);
+        status = Attributes::SoftwareVersion::Set(endpoint, firmwareRevision);
         VerifyOrReturn(EMBER_ZCL_STATUS_SUCCESS == status, ChipLogError(Zcl, "Error setting Software Version: 0x%02x", status));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ void emberAfBasicClusterServerInitCallback(chip::EndpointId endpoint)`
`87`	`87`	`uint16_t firmwareRevision;`
`88`	`88`	`if (ConfigurationMgr().GetFirmwareRevision(firmwareRevision) == CHIP_NO_ERROR)`
`89`	`89`	`{`
`90`		`- status = Attributes::HardwareVersion::Set(endpoint, firmwareRevision);`
	`90`	`+ status = Attributes::SoftwareVersion::Set(endpoint, firmwareRevision);`
`91`	`91`	`VerifyOrReturn(EMBER_ZCL_STATUS_SUCCESS == status, ChipLogError(Zcl, "Error setting Software Version: 0x%02x", status));`
`92`	`92`	`}`
`93`	`93`	`}`