From 27aa108a47ca53f8c335e6b446884eccf1220727 Mon Sep 17 00:00:00 2001
From: Justin Wood <woody@apple.com>
Date: Mon, 17 Jun 2024 12:12:43 -0700
Subject: [PATCH] Removing these errors

---
 src/darwin/Framework/CHIP/MTRDevice.mm                    | 8 +++++---
 .../CHIP/MTRDeviceStorageBehaviorConfiguration.mm         | 2 +-
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/darwin/Framework/CHIP/MTRDevice.mm b/src/darwin/Framework/CHIP/MTRDevice.mm
index 9d1853c0e3d663..7fea11ad7ae6db 100644
--- a/src/darwin/Framework/CHIP/MTRDevice.mm
+++ b/src/darwin/Framework/CHIP/MTRDevice.mm
@@ -173,8 +173,8 @@ - (void)_deviceInternalStateChanged:(MTRDevice *)device;
         UnsolicitedMessageFromPublisherHandler unsolicitedMessageFromPublisherHandler, ReportBeginHandler reportBeginHandler,
         ReportEndHandler reportEndHandler)
         : MTRBaseSubscriptionCallback(attributeReportCallback, eventReportCallback, errorCallback, resubscriptionCallback,
-            subscriptionEstablishedHandler, onDoneHandler, unsolicitedMessageFromPublisherHandler, reportBeginHandler,
-            reportEndHandler)
+              subscriptionEstablishedHandler, onDoneHandler, unsolicitedMessageFromPublisherHandler, reportBeginHandler,
+              reportEndHandler)
     {
     }
 
@@ -3619,7 +3619,9 @@ - (NSArray *)_getAttributesToReportWithReportedValues:(NSArray<NSDictionary<NSSt
         }
     }
 
-    MTR_LOG("%@ report from reported values %@", self, attributePathsToReport);
+    if (attributePathsToReport.count > 0) {
+        MTR_LOG("%@ report from reported values %@", self, attributePathsToReport);
+    }
 
     return attributesToReport;
 }
diff --git a/src/darwin/Framework/CHIP/MTRDeviceStorageBehaviorConfiguration.mm b/src/darwin/Framework/CHIP/MTRDeviceStorageBehaviorConfiguration.mm
index 4522c7e69b4ad6..6afa2358c83b06 100644
--- a/src/darwin/Framework/CHIP/MTRDeviceStorageBehaviorConfiguration.mm
+++ b/src/darwin/Framework/CHIP/MTRDeviceStorageBehaviorConfiguration.mm
@@ -75,7 +75,7 @@ - (void)checkValuesAndResetToDefaultIfNecessary
 
     // Sanity check all the values, and if any is out of range, reset to default values
     if ((_reportToPersistenceDelayTime <= 0) || (_reportToPersistenceDelayTimeMax <= 0) || (_reportToPersistenceDelayTimeMax < _reportToPersistenceDelayTime) || (_recentReportTimesMaxCount < 2) || (_timeBetweenReportsTooShortThreshold <= 0) || (_timeBetweenReportsTooShortMinThreshold <= 0) || (_timeBetweenReportsTooShortMinThreshold > _timeBetweenReportsTooShortThreshold) || (_reportToPersistenceDelayMaxMultiplier <= 1) || (_deviceReportingExcessivelyIntervalThreshold <= 0)) {
-        MTR_LOG_ERROR("%@ storage behavior: MTRDeviceStorageBehaviorConfiguration values out of bounds - resetting to default", self);
+        MTR_LOG("%@ storage behavior: MTRDeviceStorageBehaviorConfiguration values out of bounds - resetting to default", self);
 
         _reportToPersistenceDelayTime = kReportToPersistenceDelayTimeDefault;
         _reportToPersistenceDelayTimeMax = kReportToPersistenceDelayTimeMaxDefault;