Skip to content

Commit 1773713

Browse files
yunhanw-googleerjiaqing
authored andcommitted
Fix elif and doc update
1 parent 3a7e250 commit 1773713

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

scripts/tests/cirque_tests.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ RESET_COLOR="\033[0m"
4747
function __screen() {
4848
if [[ "x$GITHUB_ACTION_RUN" == "x1" ]]; then
4949
"$@"
50-
else if which screen; then
50+
elif which screen; then
5151
screen -dm "$@"
5252
else
5353
"$@"

src/test_driver/linux-cirque/README.md

+2-6
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,12 @@ There is a script for running cirque tests, you can find it at
1212

1313
## "Docker out of docker" setup
1414

15-
If you don't want cirque break your local environment, you can run
15+
If you don't want cirque break your local environment, you can enter a environment insider docker
1616

1717
```
18-
integrations/docker/images/chip-build-cirque/run.sh bash
18+
./integrations/docker/images/chip-build-cirque/run.sh --privileged --env LOG_DIR=/tmp/cirque_test_output --env CLEANUP_DOCKER_FOR_CI=1 --volume /dev/pts:/dev/pts --volume /tmp/cirque_test_output:/tmp/cirque_test_output -it -- bash
1919
```
2020

21-
To enter a environment inside docker, the following commands can be used inside the container without any change.
22-
23-
Alternatively, you can prepend `integrations/docker/images/chip-build-cirque/run.sh` to the commands in this doc.
24-
2521
## Setting up cirque environment
2622

2723
After checkout, in your local project chip directory, run:

0 commit comments

Comments
 (0)