Skip to content

Commit 1537187

Browse files
Damian-Nordicpull[bot]
authored andcommitted
[window-app] Set valid Type for Window Covering cluster (#19311)
* [window-app] Set valid Type for Window Covering cluster If Feature Map of Window Covering cluster has both LF and TL bits set, Type should be either 6 or 8. Initialize the attribute to 8 in window-app and all-clusters-app so that they can pass certification tests. Signed-off-by: Damian Krolik <[email protected]> * Fix tests
1 parent 0ad46b6 commit 1537187

File tree

9 files changed

+12
-18
lines changed

9 files changed

+12
-18
lines changed

examples/all-clusters-app/all-clusters-common/all-clusters-app.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -4363,7 +4363,7 @@ endpoint 1 {
43634363
}
43644364

43654365
server cluster WindowCovering {
4366-
ram attribute type;
4366+
ram attribute type default = 0x08;
43674367
ram attribute physicalClosedLimitLift default = 0xFFFF;
43684368
ram attribute physicalClosedLimitTilt default = 0xFFFF;
43694369
persist attribute currentPositionLift default = 0x7FFF;

examples/all-clusters-app/all-clusters-common/all-clusters-app.zap

+1-1
Original file line numberDiff line numberDiff line change
@@ -13602,7 +13602,7 @@
1360213602
"storageOption": "RAM",
1360313603
"singleton": 0,
1360413604
"bounded": 0,
13605-
"defaultValue": "0x00",
13605+
"defaultValue": "0x08",
1360613606
"reportable": 1,
1360713607
"minInterval": 0,
1360813608
"maxInterval": 65344,

examples/window-app/common/window-app.matter

+2-2
Original file line numberDiff line numberDiff line change
@@ -1893,7 +1893,7 @@ endpoint 1 {
18931893
}
18941894

18951895
server cluster WindowCovering {
1896-
ram attribute type;
1896+
ram attribute type default = 0x08;
18971897
ram attribute physicalClosedLimitLift default = 0xFFFF;
18981898
ram attribute physicalClosedLimitTilt default = 0xFFFF;
18991899
persist attribute currentPositionLift;
@@ -1939,7 +1939,7 @@ endpoint 2 {
19391939
}
19401940

19411941
server cluster WindowCovering {
1942-
ram attribute type;
1942+
ram attribute type default = 0x08;
19431943
ram attribute physicalClosedLimitLift default = 0xFFFF;
19441944
ram attribute physicalClosedLimitTilt default = 0xFFFF;
19451945
persist attribute currentPositionLift;

examples/window-app/common/window-app.zap

+5-4
Original file line numberDiff line numberDiff line change
@@ -8555,7 +8555,7 @@
85558555
"storageOption": "RAM",
85568556
"singleton": 0,
85578557
"bounded": 0,
8558-
"defaultValue": "0x00",
8558+
"defaultValue": "0x08",
85598559
"reportable": 1,
85608560
"minInterval": 0,
85618561
"maxInterval": 65344,
@@ -10189,7 +10189,7 @@
1018910189
"storageOption": "RAM",
1019010190
"singleton": 0,
1019110191
"bounded": 0,
10192-
"defaultValue": "0x00",
10192+
"defaultValue": "0x08",
1019310193
"reportable": 1,
1019410194
"minInterval": 0,
1019510195
"maxInterval": 65344,
@@ -10596,5 +10596,6 @@
1059610596
"endpointVersion": 2,
1059710597
"deviceIdentifier": 514
1059810598
}
10599-
]
10600-
}
10599+
],
10600+
"log": []
10601+
}

src/app/tests/suites/certification/Test_TC_WNCV_2_4.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ tests:
3434
attribute: "Type"
3535
PICS: A_TYPE
3636
response:
37-
value: 0
3837
constraints:
3938
type: enum8
4039
minValue: 0

zzz_generated/all-clusters-app/zap-generated/endpoint_config.h

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

zzz_generated/chip-tool/zap-generated/test/Commands.h

-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

zzz_generated/darwin-framework-tool/zap-generated/test/Commands.h

-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

zzz_generated/window-app/zap-generated/endpoint_config.h

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)