Skip to content

Commit 1319396

Browse files
manjunath-grlrestyled-commits
authored and
pull[bot]
committed
Fixes yaml script issues Oct 13 (#29747)
* Fixes issue: 677, 678, 679, 680, 689 DGWIFI-1.1 BRBINFO-2.1 FAN-1.1 MOD-1.1 ALOGIN-12.1 * Auto generated files * Restyled by whitespace * Fixes issue: 987, 675 TC-AUDIOOUTPUT-1.8 TC-BINFO-2.2 * Restyled by whitespace * Modified tests TC-DRLK-2.1 TC-DRLK-2.10 --------- Co-authored-by: Restyled.io <[email protected]>
1 parent 4815486 commit 1319396

11 files changed

+236
-158
lines changed

‎src/app/tests/suites/certification/Test_TC_ALOGIN_12_2.yaml

+37
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,43 @@ tests:
2727
- label: "Preconditions"
2828
verification: |
2929
Commission TH to DUT, if not done so already. In some cases, such as with a Casting Video Player, the TH commissions the DUT.
30+
31+
Product maker needs to provide instructions for how to trigger the command on the DUT. For comparison, the DUT behavior for this test step can be simulated using chip-tool (when DUT is a commissioner) or tv-casting-app (when DUT is a commissionee):
32+
33+
The following command on the example tv-app will launch a content app on endpoint 4:
34+
./chip-tool applicationlauncher launch-app '{"catalogVendorID": 123, "applicationID": "exampleid"}' 1 1
35+
./chip-tv-casting-app applicationlauncher launch-app '{"catalogVendorID": 123, "applicationID": "exampleid"}' 1 1
36+
On TH (tv-app), Verify the launch app command is received successfully.
37+
1666779708.066501][24994:24994] CHIP:DMG: InvokeRequestMessage =
38+
[1666779708.066504][24994:24994] CHIP:DMG: {
39+
[1666779708.066507][24994:24994] CHIP:DMG: suppressResponse = false,
40+
[1666779708.066509][24994:24994] CHIP:DMG: timedRequest = false,
41+
[1666779708.066512][24994:24994] CHIP:DMG: InvokeRequests =
42+
[1666779708.066517][24994:24994] CHIP:DMG: [
43+
[1666779708.066520][24994:24994] CHIP:DMG: CommandDataIB =
44+
[1666779708.066524][24994:24994] CHIP:DMG: {
45+
[1666779708.066527][24994:24994] CHIP:DMG: CommandPathIB =
46+
[1666779708.066532][24994:24994] CHIP:DMG: {
47+
[1666779708.066536][24994:24994] CHIP:DMG: EndpointId = 0x1,
48+
[1666779708.066540][24994:24994] CHIP:DMG: ClusterId = 0x50c,
49+
[1666779708.066545][24994:24994] CHIP:DMG: CommandId = 0x0,
50+
[1666779708.066547][24994:24994] CHIP:DMG: },
51+
[1666779708.066551][24994:24994] CHIP:DMG:
52+
[1666779708.066553][24994:24994] CHIP:DMG: CommandFields =
53+
[1666779708.066555][24994:24994] CHIP:DMG: {
54+
[1666779708.066557][24994:24994] CHIP:DMG: 0x0 =
55+
[1666779708.066560][24994:24994] CHIP:DMG: {
56+
[1666779708.066566][24994:24994] CHIP:DMG: 0x0 = 123,
57+
[1666779708.066569][24994:24994] CHIP:DMG: 0x1 = "exampleid" (9 chars),
58+
[1666779708.066572][24994:24994] CHIP:DMG: },
59+
[1666779708.066575][24994:24994] CHIP:DMG: },
60+
[1666779708.066578][24994:24994] CHIP:DMG: },
61+
[1666779708.066581][24994:24994] CHIP:DMG:
62+
[1666779708.066583][24994:24994] CHIP:DMG: ],
63+
[1666779708.066586][24994:24994] CHIP:DMG:
64+
[1666779708.066588][24994:24994] CHIP:DMG: InteractionModelRevision = 1
65+
[1666779708.066590][24994:24994] CHIP:DMG: },
66+
[1666779708.066602][24994:24994] CHIP:DMG: AccessControl: checking f=2 a=c s=0x000000000001B669 t= c=0x0000_050C e=1 p=o
3067
disabled: true
3168

3269
- label: "Step 1: DUT sends GetSetupPIN command to TH"

‎src/app/tests/suites/certification/Test_TC_AUDIOOUTPUT_1_8.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ tests:
4848
response:
4949
constraints:
5050
type: bitmap32
51-
hasMasksSet: [0x2]
51+
hasMasksSet: [0x1]
5252

5353
- label: "Step 2b: Read the global attribute: FeatureMap"
5454
PICS: " !AUDIOOUTPUT.S.F00 "
@@ -57,7 +57,7 @@ tests:
5757
response:
5858
constraints:
5959
type: bitmap32
60-
hasMasksClear: [0x2]
60+
hasMasksClear: [0x1]
6161

6262
- label: "Step 3: Read the global attribute: AttributeList"
6363
PICS: PICS_EVENT_LIST_ENABLED

‎src/app/tests/suites/certification/Test_TC_BINFO_2_2.yaml

+26-2
Original file line numberDiff line numberDiff line change
@@ -139,13 +139,37 @@ tests:
139139
minInterval: 30
140140
maxInterval: 100
141141

142-
- label: "Verify that ShutDown event has priority set as CRITICAL"
142+
- label:
143+
"Shutdown the DUT and Verify that ShutDown event has priority set as
144+
CRITICAL"
145+
verification: |
146+
To verify ShutDown event follow the below commands , Pls use equivalent command on the respective DUT
147+
148+
149+
1. Launch chip-tool into interactive mode with the command
150+
151+
./chip-tool interactive start
152+
153+
2. run below command in interactive mode shell and Turn down the DUT
154+
basicinformation subscribe-event shut-down 20 100 1 0
155+
156+
verify that ShutDown event as priority set has CRITICAL on TH(Chip-tool)
157+
158+
CHIP:TOO: Endpoint: 0 Cluster: 0x0000_0028 Event 0x0000_0001
159+
[1653050528.900202][119367:119372] CHIP:TOO: Event number: 5
160+
[1653050528.900295][119367:119372] CHIP:TOO: Priority: Critical
161+
[1653050528.900386][119367:119372] CHIP:TOO: Timestamp: 289436805
162+
[1653050528.900630][119367:119372] CHIP:TOO: ShutDown: {
163+
[1653050528.900732][119367:119372] CHIP:TOO: }
164+
[1653050528.900892][119367:119372] CHIP:DMG: Refresh LivenessCheckTime for 28000 milliseconds with SubscriptionId = 0x27408c83 Peer = 01:0000000000000001
143165
cluster: "LogCommands"
144166
command: "UserPrompt"
145167
PICS: PICS_SKIP_SAMPLE_APP && BINFO.S.E01
146168
arguments:
147169
values:
148170
- name: "message"
149-
value: "If priority set as CRITICAL enter 'y' for success"
171+
value:
172+
"Enter 'y' after successfully ShutDown DUT & priority set as
173+
CRITICAL"
150174
- name: "expectedValue"
151175
value: "y"

‎src/app/tests/suites/certification/Test_TC_BRBINFO_2_1.yaml

+8-5
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,9 @@ tests:
172172
verification: |
173173
./chip-tool bridgeddevicebasicinformation write node-label '"newnode"' 1 3
174174
175-
Verify response has unsupported write on TH(chip-tool) Log:
175+
Via the TH (chip-tool), verify the SUCCESS response for NodeLabel attribute write function.
176+
177+
Current sample apps do not have this implementation. However, if the vendor has implemented it, the below response will be displayed.
176178
177179
NOTE the quotes: single-quote/double-quote/string/double-quote/single-quote
178180
@@ -181,7 +183,7 @@ tests:
181183
[1660839701.840505][2444:2449] CHIP:DMG:
182184
[1660839701.840578][2444:2449] CHIP:DMG: StatusIB =
183185
[1660839701.840661][2444:2449] CHIP:DMG: {
184-
[1660839701.840742][2444:2449] CHIP:DMG: status = 0x88 (UNSUPPORTED_WRITE),
186+
[1660839701.840742][2444:2449] CHIP:DMG: status = 0x00 (SUCCESS),
185187
[1660839701.840827][2444:2449] CHIP:DMG: },
186188
[1660839701.840905][2444:2449] CHIP:DMG:
187189
[1660839701.840973][2444:2449] CHIP:DMG: },
@@ -199,11 +201,12 @@ tests:
199201
verification: |
200202
./chip-tool bridgeddevicebasicinformation read node-label 1 3
201203
202-
Verify the value of node-label is type of string and contains length between 0 and 32 in TH(chip-tool) Log:
203-
Note: If the write access is implemented then the value of the of the Nodelabel will be changed into "newnode"
204+
Via the TH (chip-tool), verify that the NodeLabel attribute value is changed to newnode.
205+
206+
Current sample apps do not have this implementation. However, if the vendor has implemented it, the below response will be displayed.
204207
205208
[1657696463.081741][15476:15481] CHIP:TOO: Endpoint: 3 Cluster: 0x0000_0039 Attribute 0x0000_0005 DataVersion: 2577979325
206-
[1657696463.081791][15476:15481] CHIP:TOO: NodeLabel: Light 1
209+
[1657696463.081791][15476:15481] CHIP:TOO: NodeLabel: newnode
207210
cluster: "LogCommands"
208211
command: "UserPrompt"
209212
arguments:

‎src/app/tests/suites/certification/Test_TC_DGWIFI_1_1.yaml

+35-32
Original file line numberDiff line numberDiff line change
@@ -122,35 +122,7 @@ tests:
122122
type: list
123123
contains: [11]
124124

125-
- label: "Step 5a: TH reads AcceptedCommandList from DUT"
126-
PICS: " !DGWIFI.S.F01 "
127-
command: "readAttribute"
128-
attribute: "AcceptedCommandList"
129-
response:
130-
value: []
131-
constraints:
132-
type: list
133-
134-
- label:
135-
"Step 5b: TH reads Feature dependent(DGWIFI.S.F01) command in
136-
AcceptedCommandList from DUT"
137-
PICS: DGWIFI.S.F01
138-
command: "readAttribute"
139-
attribute: "AcceptedCommandList"
140-
response:
141-
constraints:
142-
type: list
143-
contains: [0]
144-
145-
- label: "Step 6: TH reads GeneratedCommandList from DUT"
146-
command: "readAttribute"
147-
attribute: "GeneratedCommandList"
148-
response:
149-
value: []
150-
constraints:
151-
type: list
152-
153-
- label: "Step 7a: TH reads EventList from DUT"
125+
- label: "Step 5a: TH reads EventList from DUT"
154126
PICS:
155127
" !DGWIFI.S.E00 && !DGWIFI.S.E01 && !DGWIFI.S.E02 &&
156128
PICS_EVENT_LIST_ENABLED"
@@ -160,8 +132,9 @@ tests:
160132
value: []
161133
constraints:
162134
type: list
135+
163136
- label:
164-
"Step 7b: TH reads optional attribute (Disconnection) in EventList
137+
"Step 5b: TH reads optional attribute (Disconnection) in EventList
165138
from DUT"
166139
PICS: DGWIFI.S.E00 && PICS_EVENT_LIST_ENABLED
167140
command: "readAttribute"
@@ -170,8 +143,9 @@ tests:
170143
constraints:
171144
type: list
172145
contains: [0]
146+
173147
- label:
174-
"Step 7c: TH reads optional attribute (AssociationFailure) in
148+
"Step 5c: TH reads optional attribute (AssociationFailure) in
175149
EventList from DUT"
176150
PICS: DGWIFI.S.E01 && PICS_EVENT_LIST_ENABLED
177151
command: "readAttribute"
@@ -180,8 +154,9 @@ tests:
180154
constraints:
181155
type: list
182156
contains: [1]
157+
183158
- label:
184-
"Step 7d: TH reads optional attribute (ConnectionStatus) in EventList
159+
"Step 5d: TH reads optional attribute (ConnectionStatus) in EventList
185160
from DUT"
186161
PICS: DGWIFI.S.E02 && PICS_EVENT_LIST_ENABLED
187162
command: "readAttribute"
@@ -190,3 +165,31 @@ tests:
190165
constraints:
191166
type: list
192167
contains: [2]
168+
169+
- label: "Step 6a: TH reads AcceptedCommandList from DUT"
170+
PICS: " !DGWIFI.S.F01 "
171+
command: "readAttribute"
172+
attribute: "AcceptedCommandList"
173+
response:
174+
value: []
175+
constraints:
176+
type: list
177+
178+
- label:
179+
"Step 6b: TH reads Feature dependent(DGWIFI.S.F01) command in
180+
AcceptedCommandList from DUT"
181+
PICS: DGWIFI.S.F01
182+
command: "readAttribute"
183+
attribute: "AcceptedCommandList"
184+
response:
185+
constraints:
186+
type: list
187+
contains: [0]
188+
189+
- label: "Step 7: TH reads GeneratedCommandList from DUT"
190+
command: "readAttribute"
191+
attribute: "GeneratedCommandList"
192+
response:
193+
value: []
194+
constraints:
195+
type: list

‎src/app/tests/suites/certification/Test_TC_DRLK_2_1.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ tests:
248248
minValue: 0
249249
maxValue: 11
250250

251-
- label: "Step 2c: TH writes LockType attribute as 10"
251+
- label: "Step 2b: TH writes LockType attribute as 10"
252252
PICS: DRLK.S.A0001
253253
command: "writeAttribute"
254254
attribute: "LockType"

‎src/app/tests/suites/certification/Test_TC_DRLK_2_10.yaml

+2-11
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,7 @@ tests:
450450
0-Single"
451451
PICS: DRLK.S.F08 && DRLK.S.C1a.Rsp
452452
verification: |
453-
./chip-tool doorlock set-user 0 2 xxx 6452 3 0 0 1 1 --timedInteractionTimeoutMs 1000
453+
./chip-tool doorlock set-user 0 2 xxx 6452 1 0 0 1 1 --timedInteractionTimeoutMs 1000
454454
455455
Via the TH (chip-tool), verify the SUCCESS response for setting the users details.
456456
@@ -459,15 +459,6 @@ tests:
459459
[1658994912.123915][4290:4295] CHIP:DMG: status = 0x00 (SUCCESS),
460460
[1658994912.123959][4290:4295] CHIP:DMG: },
461461
[1658994912.124003][4290:4295] CHIP:DMG:
462-
[1658994912.124039][4290:4295] CHIP:DMG: },
463-
[1658994912.124079][4290:4295] CHIP:DMG:
464-
[1658994912.124110][4290:4295] CHIP:DMG: },
465-
[1658994912.124147][4290:4295] CHIP:DMG:
466-
[1658994912.124176][4290:4295] CHIP:DMG: ],
467-
[1658994912.124212][4290:4295] CHIP:DMG:
468-
[1658994912.124241][4290:4295] CHIP:DMG: InteractionModelRevision = 1
469-
[1658994912.124270][4290:4295] CHIP:DMG: },
470-
[1658994912.124341][4290:4295] CHIP:DMG: Received Command Response Status for Endpoint=1 Cluster=0x0000_0101 Command=0x0000_001A Status=0x0
471462
disabled: true
472463

473464
- label: "Step 5b: TH reads the LockUserChange event from DUT"
@@ -631,7 +622,7 @@ tests:
631622
[1658995364.178185][4383:4388] CHIP:DMG: },
632623
633624
634-
./chip-tool doorlock set-user 0 1 xxx 6452 3 0 0 1 1 --timedInteractionTimeoutMs 1000
625+
./chip-tool doorlock set-user 0 1 xxx 6452 1 0 0 1 1 --timedInteractionTimeoutMs 1000
635626
636627
Via the TH (chip-tool), verify the SUCCESS response for setting the users details.
637628

‎src/app/tests/suites/certification/Test_TC_FAN_1_1.yaml

+15-6
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ tests:
116116
type: bitmap32
117117
hasMasksSet: [0x20]
118118

119-
- label: "Step 4: Read the global attribute: AttributeList"
119+
- label: "Step 4a: Read the global attribute: AttributeList"
120120
PICS: PICS_EVENT_LIST_ENABLED
121121
command: "readAttribute"
122122
attribute: "AttributeList"
@@ -125,7 +125,7 @@ tests:
125125
type: list
126126
contains: [0, 1, 2, 3, 65528, 65529, 65530, 65531, 65532, 65533]
127127

128-
- label: "Step 4: Read the global attribute: AttributeList"
128+
- label: "Step 4a: Read the global attribute: AttributeList"
129129
PICS: "!PICS_EVENT_LIST_ENABLED"
130130
command: "readAttribute"
131131
attribute: "AttributeList"
@@ -135,7 +135,7 @@ tests:
135135
contains: [0, 1, 2, 3, 65528, 65529, 65531, 65532, 65533]
136136

137137
- label:
138-
"Step 4: Read the feature dependent FAN.S.F00 (SPD) attribute in
138+
"Step 4c: Read the feature dependent FAN.S.F00 (SPD) attribute in
139139
AttributeList"
140140
PICS: FAN.S.F00
141141
command: "readAttribute"
@@ -146,7 +146,7 @@ tests:
146146
contains: [4, 5, 6]
147147

148148
- label:
149-
"Step 4: Read the feature dependent FAN.S.F02(RCK) attribute in
149+
"Step 4d: Read the feature dependent FAN.S.F02(RCK) attribute in
150150
AttributeList"
151151
PICS: FAN.S.F02
152152
command: "readAttribute"
@@ -157,7 +157,7 @@ tests:
157157
contains: [7, 8]
158158

159159
- label:
160-
"Step 4: Read the feature dependent FAN.S.F03(WND) attribute in
160+
"Step 4e: Read the feature dependent FAN.S.F03(WND) attribute in
161161
AttributeList"
162162
PICS: FAN.S.F03
163163
command: "readAttribute"
@@ -168,7 +168,7 @@ tests:
168168
contains: [9, 10]
169169

170170
- label:
171-
"Step 4: Read the feature dependent FAN.S.F05(DIR) attribute in
171+
"Step 4f: Read the feature dependent FAN.S.F05(DIR) attribute in
172172
AttributeList"
173173
PICS: FAN.S.F05
174174
command: "readAttribute"
@@ -178,6 +178,15 @@ tests:
178178
type: list
179179
contains: [11]
180180

181+
- label: "Step 5: TH reads EventList attribute from DUT"
182+
PICS: PICS_EVENT_LIST_ENABLED
183+
command: "readAttribute"
184+
attribute: "EventList"
185+
response:
186+
value: []
187+
constraints:
188+
type: list
189+
181190
- label: "Step 6: Read the global attribute: AcceptedCommandList"
182191
PICS: " !FAN.S.C00.Rsp "
183192
command: "readAttribute"

‎src/app/tests/suites/certification/Test_TC_MOD_1_1.yaml

+7-17
Original file line numberDiff line numberDiff line change
@@ -31,23 +31,13 @@ tests:
3131
- name: "nodeId"
3232
value: nodeId
3333

34-
#Issue: https://github.com/project-chip/connectedhomeip/issues/26445
35-
- label: "Step 2: TH reads the ClusterRevision attribute from the DUT"
36-
verification: |
37-
./chip-tool modeselect read cluster-revision 1 1
38-
39-
Verify the "ClusterRevision" value is of unit16 and reflects the highest revision number 2 on the TH(Chip-tool) and below is the sample log provided for the raspi platform:
40-
41-
[1645775623.658997][3277:3282] CHIP:TOO: ClusterRevision: 1
42-
cluster: "LogCommands"
43-
command: "UserPrompt"
44-
PICS: PICS_USER_PROMPT
45-
arguments:
46-
values:
47-
- name: "message"
48-
value: "Please enter 'y' for success"
49-
- name: "expectedValue"
50-
value: "y"
34+
- label: "Step 2: Read the global attribute: ClusterRevision"
35+
command: "readAttribute"
36+
attribute: "ClusterRevision"
37+
response:
38+
value: 2
39+
constraints:
40+
type: int16u
5141

5242
- label: "Step 3: TH reads the FeatureMap attribute from the DUT"
5343
PICS: MOD.S.F00

‎src/app/tests/suites/certification/ci-pics-values

+1-1
Original file line numberDiff line numberDiff line change
@@ -447,7 +447,7 @@ AUDIOOUTPUT.S.C01.Rsp=1
447447
AUDIOOUTPUT.C=1
448448
AUDIOOUTPUT.C.C00.Tx=1
449449
AUDIOOUTPUT.C.C01.Tx=1
450-
AUDIOOUTPUT.S.F00=0
450+
AUDIOOUTPUT.S.F00=1
451451

452452
TGTNAV.S=1
453453
TGTNAV.S.A0000=1

0 commit comments

Comments
 (0)