[mdns] Show interface on mDns failures. (#15266)

turon · pull[bot] · commit 1209331ea941 · 2023-10-31T22:34:02.000Z
* [mdns] Show interface on mDns failures.

* [log] Deescalate bad interface log from error to detail.

* [mdns] Comment resolution.

* [mdns] Handle interface name error.

* [restyle]
diff --git a/src/lib/dnssd/minimal_mdns/Server.cpp b/src/lib/dnssd/minimal_mdns/Server.cpp
@@ -386,8 +386,14 @@ CHIP_ERROR ServerBase::BroadcastImpl(chip::System::PacketBufferHandle && data, u
             }
             else
             {
-                ChipLogError(Discovery, "Attempt to mDNS broadcast failed:  %s", chip::ErrorStr(err));
                 lastError = err;
+#if CHIP_DETAIL_LOGGING
+                char ifaceName[chip::Inet::InterfaceId::kMaxIfNameLength];
+                err = info->mInterfaceId.GetInterfaceName(ifaceName, sizeof(ifaceName));
+                if (err != CHIP_NO_ERROR)
+                    strcpy(ifaceName, "???");
+                ChipLogDetail(Discovery, "Warning: Attempt to mDNS broadcast failed on %s:  %s", ifaceName, lastError.AsString());
+#endif
             }
             return chip::Loop::Continue;
         }))

Original file line number	Diff line number	Diff line change
`@@ -386,8 +386,14 @@ CHIP_ERROR ServerBase::BroadcastImpl(chip::System::PacketBufferHandle && data, u`
`386`	`386`	`}`
`387`	`387`	`else`
`388`	`388`	`{`
`389`		`- ChipLogError(Discovery, "Attempt to mDNS broadcast failed: %s", chip::ErrorStr(err));`
`390`	`389`	`lastError = err;`
	`390`	`+#if CHIP_DETAIL_LOGGING`
	`391`	`+ char ifaceName[chip::Inet::InterfaceId::kMaxIfNameLength];`
	`392`	`+ err = info->mInterfaceId.GetInterfaceName(ifaceName, sizeof(ifaceName));`
	`393`	`+ if (err != CHIP_NO_ERROR)`
	`394`	`+ strcpy(ifaceName, "???");`
	`395`	`+ ChipLogDetail(Discovery, "Warning: Attempt to mDNS broadcast failed on %s: %s", ifaceName, lastError.AsString());`
	`396`	`+#endif`
`391`	`397`	`}`
`392`	`398`	`return chip::Loop::Continue;`
`393`	`399`	`}))`