Disable the check via a nolint

andy31415 · andy31415 · commit 052657cfd668 · 2024-04-29T12:19:10.000-04:00
diff --git a/src/lib/dnssd/tests/TestActiveResolveAttempts.cpp b/src/lib/dnssd/tests/TestActiveResolveAttempts.cpp
@@ -268,7 +268,8 @@ TEST(TestActiveResolveAttempts, TestLRU)
         std::optional<ActiveResolveAttempts::ScheduledAttempt> s = attempts.NextScheduled();
         while (s.has_value())
         {
-            EXPECT_NE(s.value().ResolveData().peerId.GetNodeId(), 9999u);
+            // NOLINTNEXTLINE(bugprone-unchecked-optional-access): this is checked in the while loop
+            EXPECT_NE(s->ResolveData().peerId.GetNodeId(), 9999u);
             s = attempts.NextScheduled();
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,8 @@ TEST(TestActiveResolveAttempts, TestLRU)`
`268`	`268`	`std::optional<ActiveResolveAttempts::ScheduledAttempt> s = attempts.NextScheduled();`
`269`	`269`	`while (s.has_value())`
`270`	`270`	`{`
`271`		`- EXPECT_NE(s.value().ResolveData().peerId.GetNodeId(), 9999u);`
	`271`	`+ // NOLINTNEXTLINE(bugprone-unchecked-optional-access): this is checked in the while loop`
	`272`	`+ EXPECT_NE(s->ResolveData().peerId.GetNodeId(), 9999u);`
`272`	`273`	`s = attempts.NextScheduled();`
`273`	`274`	`}`
`274`	`275`	`}`